A few tweaks to QueueBundle.Remove implementation#1240
Open
A few tweaks to QueueBundle.Remove implementation#1240
QueueBundle.Remove implementation#1240Conversation
This builds on #1235 to bring in a few tweaks: * Removing a queue is a blocking operation because it needs to wait for the producer to finish up its jobs and shut down. It'd be better to provide a way for this not to block forever, so here we add a context parameter to `QueueBundle.Remove` similar to the one taken by `Client.Stop`. If the client becomes done before the producer resolves, `QueueBundle.Remove` falls through with the error. * Add a "stress" test case for `QueueBundle.Remove`. It's meant to detect a deadlock or other concurrency bug in case there is one and gives us a little more confidence that what we have here is right. * Renamed `addProducer` and `removeProducer` to `producerAdd` and `producerRemove` so they sort more nicely against each other. * Add changelogentry.
brandur
force-pushed
the
brandur-queue-bundle-remove-improvements
branch
from
3f49ca4 to
6438bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1235 to bring in a few tweaks:
Removing a queue is a blocking operation because it needs to wait for
the producer to finish up its jobs and shut down. It'd be better to
provide a way for this not to block forever, so here we add a context
parameter to
QueueBundle.Removesimilar to the one taken byClient.Stop. If the client becomes done before the producerresolves,
QueueBundle.Removefalls through with the error.Add a "stress" test case for
QueueBundle.Remove. It's meant todetect a deadlock or other concurrency bug in case there is one and
gives us a little more confidence that what we have here is right.
Renamed
addProducerandremoveProducertoproducerAddandproducerRemoveso they sort more nicely against each other.Add changelogentry.