Skip to content

[ci] Add a couple of Windows jobs to GHA #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ricab wants to merge 4 commits into
base: main
Choose a base branch
from
+25 −8
Draft

[ci] Add a couple of Windows jobs to GHA #41

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0911a6
[ci] Add a couple of Windows jobs to GHA
ricab Jan 7, 2026
1ba1a4f
[ci] Determine the number of cpus on windows
ricab Jan 7, 2026
bf3c13f
[ci] Use generic syntax for var expansion
ricab Jan 7, 2026
ba3a0e3
[ci] Adapt compilation tests to support Windows
ricab Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ jobs:
# AppleClang on macOS
- os: macos-15
comp: AppleClang # default compiler, unused var to show in GH UI
# MSVC on Windows
- os: windows-2019
comp: MSVC # Visual Studio 2019 ATTOW
- os: windows-2025
comp: MSVC # Visual Studio 2022 ATTOW

runs-on: ${{matrix.os}}
steps:
Expand All @@ -69,30 +74,42 @@ jobs:

- name: Determine number of cpus on Linux
if: startsWith(matrix.os, 'ubuntu')
run: echo "num_cpus=$(nproc)" >> $GITHUB_ENV # TODO use set-output instead
run: echo "num_cpus=$(nproc)" >> $GITHUB_ENV

- name: Determine number of cpus on macOS
if: startsWith(matrix.os, 'macos')
run: echo "num_cpus=$(sysctl -n hw.ncpu)" >> $GITHUB_ENV # TODO use set-output instead
run: echo "num_cpus=$(sysctl -n hw.ncpu)" >> $GITHUB_ENV

- name: Determine number of cpus on Windows
if: startsWith(matrix.os, 'windows')
run: echo "num_cpus=$env:NUMBER_OF_PROCESSORS" >> $env:GITHUB_ENV

- name: Determine number of compilation test jobs on macOS and Linux
if: ${{ !startsWith(matrix.os, 'windows') }}
shell: bash
run: echo "num_comp_tests=$((${{env.num_cpus}} * 2))" >> $GITHUB_ENV

- name: Determine number of compilation test jobs on Windows
if: startsWith(matrix.os, 'windows')
shell: bash
run: echo "num_comp_tests=1" >> $GITHUB_ENV

- name: Determine compiler flag
if: ${{matrix.compiler}}
run: echo "CXX=${{matrix.compiler}}" >> $GITHUB_ENV

- name: Configure CMake
run: cmake -Wdev -Werror=dev -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${BUILD_TYPE}
run: cmake -Wdev -Werror=dev -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
${{matrix.extra_build_flags}}

- name: Build
working-directory: ${{github.workspace}}/build
run: cmake --build . --config ${BUILD_TYPE} --parallel ${num_cpus}
run: cmake --build . --config ${{env.BUILD_TYPE}} --parallel ${{env.num_cpus}}

- name: Test
working-directory: ${{github.workspace}}/build
run: cmake --build . --config ${BUILD_TYPE} --target test
ARGS=-j$((${num_cpus} * 2)) # don't pass --parallel, which would affect compilation tests,
# but do run twice as many compilation tests as the number of
# available threads
run: cmake --build . --config ${{env.BUILD_TYPE}} --target test
ARGS=-j${{env.num_comp_tests}} # don't pass --parallel, which would affect compilation tests

- name: Produce coverage reports
if: contains(matrix.extra_build_flags, 'coverage')
Expand Down
Loading