Remove kafka tests.#67
Merged
slinkydeveloper merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
tillrohrmann
approved these changes
Jan 27, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for cleaning up our sdk-test-suite @slinkydeveloper. I am wondering whether we should move the removed tests to the e2e test suite as the Kafka tests there seem to test slightly different aspects.
Comment on lines
-68
to
-145
| @Test | ||
| @Execution(ExecutionMode.CONCURRENT) | ||
| fun handleEventInCounterService( | ||
| @InjectAdminURI adminURI: URI, | ||
| @InjectContainerPort(hostName = "kafka", port = KafkaContainer.KAFKA_EXTERNAL_PORT) | ||
| kafkaPort: Int, | ||
| @InjectClient ingressClient: Client | ||
| ) = runTest { | ||
| val counter = UUID.randomUUID().toString() | ||
|
|
||
| // Create subscription | ||
| val subscriptionsClient = | ||
| SubscriptionApi(ApiClient().setHost(adminURI.host).setPort(adminURI.port)) | ||
| subscriptionsClient.createSubscription( | ||
| CreateSubscriptionRequest() | ||
| .source("kafka://my-cluster/$COUNTER_TOPIC") | ||
| .sink("service://${CounterHandlers.Metadata.SERVICE_NAME}/add") | ||
| .options(mapOf("auto.offset.reset" to "earliest"))) | ||
|
|
||
| // Produce message to kafka | ||
| produceMessageToKafka( | ||
| "PLAINTEXT://localhost:$kafkaPort", | ||
| COUNTER_TOPIC, | ||
| listOf(counter to "1", counter to "2", counter to "3")) | ||
|
|
||
| await withAlias | ||
| "Updates from Kafka are visible in the counter" untilAsserted | ||
| { | ||
| assertThat(CounterClient.fromClient(ingressClient, counter).get()).isEqualTo(6L) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| @Execution(ExecutionMode.CONCURRENT) | ||
| fun handleEventInEventHandler( | ||
| @InjectAdminURI adminURI: URI, | ||
| @InjectContainerPort(hostName = "kafka", port = KafkaContainer.KAFKA_EXTERNAL_PORT) | ||
| kafkaPort: Int, | ||
| @InjectClient ingressClient: Client | ||
| ) = runTest { | ||
| val counter = UUID.randomUUID().toString() | ||
|
|
||
| // Create subscription | ||
| val subscriptionsClient = | ||
| SubscriptionApi(ApiClient().setHost(adminURI.host).setPort(adminURI.port)) | ||
| subscriptionsClient.createSubscription( | ||
| CreateSubscriptionRequest() | ||
| .source("kafka://my-cluster/$EVENT_HANDLER_TOPIC") | ||
| .sink("service://${ProxyHandlers.Metadata.SERVICE_NAME}/oneWayCall") | ||
| .options(mapOf("auto.offset.reset" to "earliest"))) | ||
|
|
||
| // Produce message to kafka | ||
| produceMessageToKafka( | ||
| "PLAINTEXT://localhost:$kafkaPort", | ||
| EVENT_HANDLER_TOPIC, | ||
| listOf( | ||
| null to | ||
| Json.encodeToString( | ||
| ProxyRequest( | ||
| CounterHandlers.Metadata.SERVICE_NAME, | ||
| counter, | ||
| "add", | ||
| Json.encodeToString(1).encodeToByteArray())), | ||
| null to | ||
| Json.encodeToString( | ||
| ProxyRequest( | ||
| CounterHandlers.Metadata.SERVICE_NAME, | ||
| counter, | ||
| "add", | ||
| Json.encodeToString(2).encodeToByteArray())), | ||
| null to | ||
| Json.encodeToString( | ||
| ProxyRequest( | ||
| CounterHandlers.Metadata.SERVICE_NAME, | ||
| counter, | ||
| "add", | ||
| Json.encodeToString(3).encodeToByteArray())), | ||
| )) |
Contributor
There was a problem hiding this comment.
Does it make sense to move those tests to the e2e repo? We seem to test workflows and tracing in the e2e tests but not handleEventInEventHandler and not explicitly handleEventInCounterService.
Collaborator
Author
There was a problem hiding this comment.
Its' here part of this restatedev/e2e#404
We don't need per SDK coverage, these tests primarily test a runtime feature already largely covered by the e2e tests.
slinkydeveloper
force-pushed
the
remove-kafka
branch
from
fe6a3da to
162f25c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need per SDK coverage, these tests primarily test a runtime feature already largely covered by the e2e tests.