feat: optionally allow dispatching the current route#66
Open
hedgepigdaniel wants to merge 1 commit intomasterfrom
Open
feat: optionally allow dispatching the current route#66hedgepigdaniel wants to merge 1 commit intomasterfrom
hedgepigdaniel wants to merge 1 commit intomasterfrom
Conversation
hedgepigdaniel
force-pushed
the
feat/disable-double-dispatch
branch
from
7f77d18 to
5c7a03a
Compare
hedgepigdaniel
force-pushed
the
feat/disable-double-dispatch
branch
from
5c7a03a to
94e4589
Compare
hedgepigdaniel
force-pushed
the
feat/disable-double-dispatch
branch
from
94e4589 to
90b9360
Compare
… preventDoubleDispatch middleware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change factors out the
isDoubleDispatchcheck (designed to prevent accidental dispatching of duplicate actions due to multiple clicks by the user) into its own middleware. The check can be disabled by passing a custommiddlewaresarg tocreateRouterand not including the new middlewarepreventDoubleDispatch.Fixes #49
BREAKING CHANGE:
transformActionno longer prevents double dispatches