Skip to content

Comments

Fix inlay hints reading from disk instead of editor buffer#8250

Draft
shulhi wants to merge 2 commits intorescript-lang:masterfrom
shulhi:fix-inlay-hint-file-source
Draft

Fix inlay hints reading from disk instead of editor buffer#8250
shulhi wants to merge 2 commits intorescript-lang:masterfrom
shulhi:fix-inlay-hint-file-source

Conversation

@shulhi
Copy link
Member

@shulhi shulhi commented Feb 22, 2026

The inlay hints doesn't read the document from the buffer, but instead read it from disk. This causes stale position location when the document is edited, at least until you saved it. This stale position interferes with user inputs as well (see video).

This fixed it by reading from the buffer just like completion, etc. See rescript-lang/rescript-vscode#1179

Before/After.

Screen.Recording.2026-02-22.at.10.55.28.AM.mov
Screen.Recording.2026-02-22.at.11.04.41.AM.mov

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 22, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8250

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8250

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8250

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8250

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8250

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8250

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8250

commit: f96d112

@shulhi shulhi requested review from nojaf and zth February 22, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant