Fix truncated Opus tail in streaming writer#450
Closed
slime-turing wants to merge 1 commit intoremsky:masterfrom
Closed
Fix truncated Opus tail in streaming writer#450slime-turing wants to merge 1 commit intoremsky:masterfrom
slime-turing wants to merge 1 commit intoremsky:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The in-memory Opus path was reading the output buffer before the muxer finished flushing on container close. That left the final Ogg/Opus pages out of the last response chunk, which shortened clips and could clip the final word.
Testing
PYTHONPATH=$PWD .venv/bin/python -m pytest api/tests/test_audio_service.py -qPYTHONPATH=$PWD .venv/bin/python -m pytest api/tests/test_openai_endpoints.py -q -k "speech_endpoint or speech_streaming or speech_pcm_streaming"