Skip to content

feat: support node: protocol in @esbuild-plugins/node-modules-polyfill #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remorses merged 1 commit into from
Jan 23, 2023
Merged

feat: support node: protocol in @esbuild-plugins/node-modules-polyfill #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions node-modules-polyfill/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ export function NodeModulesPolyfillPlugin(
args: esbuild.OnLoadArgs,
): Promise<esbuild.OnLoadResult> {
try {
const argsPath = args.path.replace(/^node:/, '')
const isCommonjs = args.namespace.endsWith('commonjs')

const resolved = polyfilledBuiltins.get(
removeEndingSlash(args.path),
removeEndingSlash(argsPath),
)
const contents = await (
await fs.promises.readFile(resolved)
Expand All @@ -62,7 +63,7 @@ export function NodeModulesPolyfillPlugin(
return {
loader: 'js',
contents: commonJsTemplate({
importPath: args.path,
importPath: argsPath,
}),
resolveDir,
}
Expand All @@ -83,12 +84,18 @@ export function NodeModulesPolyfillPlugin(
onLoad({ filter: /.*/, namespace }, loader)
onLoad({ filter: /.*/, namespace: commonjsNamespace }, loader)
const filter = new RegExp(
polyfilledBuiltinsNames.map(escapeStringRegexp).join('|'), // TODO builtins could end with slash, keep in mind in regex
[
...polyfilledBuiltinsNames,
...polyfilledBuiltinsNames.map((n) => `node:${n}`),
]
.map(escapeStringRegexp)
.join('|'), // TODO builtins could end with slash, keep in mind in regex
)
async function resolver(args: OnResolveArgs) {
const argsPath = args.path.replace(/^node:/, '')
const ignoreRequire = args.namespace === commonjsNamespace

if (!polyfilledBuiltins.has(args.path)) {
if (!polyfilledBuiltins.has(argsPath)) {
return
}

Expand All @@ -97,7 +104,7 @@ export function NodeModulesPolyfillPlugin(

return {
namespace: isCommonjs ? commonjsNamespace : namespace,
path: args.path,
path: argsPath,
}
}
onResolve({ filter }, resolver)
Expand Down