fix(core): stop spinning on terminal read errors#97
Open
liamg wants to merge 1 commit intoreeflective:masterfrom
Open
fix(core): stop spinning on terminal read errors#97liamg wants to merge 1 commit intoreeflective:masterfrom
liamg wants to merge 1 commit intoreeflective:masterfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 33.03% 32.84% -0.19%
==========================================
Files 57 58 +1
Lines 9109 9224 +115
==========================================
+ Hits 3009 3030 +21
- Misses 6062 6154 +92
- Partials 38 40 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Awesome !!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readline()so callers can exit cleanly when the tty disappearsProblem
When stdin starts returning a non-EOF read error, the Unix key-reading path currently ignores it and returns an empty key buffer.
WaitAvailableKeys()then loops forever, allocating a fresh buffer each time and burning CPU in the input loop.