Skip to content

Fix Salesforce: replace orphan processor wrapper with three input wrappers#592

Open
Feediver1 wants to merge 1 commit into
mainfrom
fix-salesforce-orphan-processor-wrapper
Open

Fix Salesforce: replace orphan processor wrapper with three input wrappers#592
Feediver1 wants to merge 1 commit into
mainfrom
fix-salesforce-orphan-processor-wrapper

Conversation

@Feediver1
Copy link
Copy Markdown
Contributor

Summary

Connect v4.91.0 (rp-connect-docs commit eb5b720, 2026-05-11) restructured Salesforce upstream:

Before v4.91.0 After v4.91.0
processors/salesforce.adoc removed
inputs/salesforce.adoc (new)
inputs/salesforce_cdc.adoc (new)
inputs/salesforce_graphql.adoc (new)

Cloud-docs PR #567 had added a processor wrapper on 2026-05-01, 10 days before the upstream restructure. The orphan include has been failing the cloud-docs build with three errors:

ERROR (asciidoctor): target of include not found:
  redpanda-connect:components:processors/salesforce.adoc
  file: modules/develop/pages/connect/components/processors/salesforce.adoc:3

ERROR (asciidoctor): target of xref not found:
  components:inputs/salesforce_cdc.adoc

ERROR (asciidoctor): target of xref not found:
  components:inputs/salesforce_graphql.adoc

Changes

  • Deleted modules/develop/pages/connect/components/processors/salesforce.adoc (orphan wrapper)
  • Added three input wrappers under .../components/inputs/ following the established three-line wrapper pattern that the rest of the input wrappers use (= name / :page-aliases: components:inputs/name.adoc / include::redpanda-connect:components:inputs/name.adoc[tag=single-source])
  • Preserved the old processor URL via :page-aliases: components:processors/salesforce.adoc on the new inputs/salesforce.adoc wrapper so any external links to the old processor path still resolve
  • Updated modules/ROOT/nav.adoc:
    • Removed the processor nav entry
    • Inserted three input entries alphabetically (after resource.adoc)
  • Updated modules/get-started/pages/whats-new-cloud.adoc (May 2026 section):
    • Removed the (incorrect) salesforce processor entry
    • Added a new * Inputs: subheading with the three new salesforce input descriptions sourced from the upstream source pages

Preview pages

  • Salesforce input wrappers will render once Netlify builds. Expected at:
    • https://deploy-preview-<n>--rp-cloud.netlify.app/redpanda-cloud/develop/connect/components/inputs/salesforce/
    • .../inputs/salesforce_cdc/
    • .../inputs/salesforce_graphql/

Test plan

  • Netlify deploy preview is green (no asciidoctor include / xref errors for salesforce).
  • All three new input wrappers render with content from the upstream source pages.
  • The old processor URL (/redpanda-cloud/develop/connect/components/processors/salesforce/) redirects to the new /inputs/salesforce/ page via the :page-aliases: entry.
  • Nav shows the three new inputs in alphabetical position and no longer shows the processor entry.

🤖 Generated with Claude Code

…ppers

Connect v4.91.0 (rp-connect-docs commit eb5b720, 2026-05-11) restructured
Salesforce upstream: the salesforce processor was removed and three new
input pages were added (salesforce, salesforce_cdc, salesforce_graphql).

Cloud-docs PR #567 had added a processor wrapper on 2026-05-01, 10 days
before the upstream restructure. The orphan include has been failing the
cloud-docs build with:

  ERROR (asciidoctor): target of include not found:
    redpanda-connect:components:processors/salesforce.adoc

Plus two follow-on xref errors for the new input siblings.

This change:
- Deletes modules/develop/pages/connect/components/processors/salesforce.adoc
- Adds three input wrappers under .../components/inputs/ following the
  established 3-line wrapper pattern
- Preserves the old processor URL via :page-aliases: on the new
  inputs/salesforce.adoc wrapper for any external links
- Updates nav.adoc: removes the processor entry, inserts the three input
  entries alphabetically after resource.adoc
- Updates whats-new-cloud.adoc May 2026 entry: removes the (incorrect)
  salesforce processor line and adds the three new inputs under a new
  Inputs: subheading

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Feediver1 Feediver1 requested a review from a team as a code owner May 19, 2026 20:33
@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 540c9ea
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/6a0cc92c6a17510008b949c3
😎 Deploy Preview https://deploy-preview-592--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f58db0d4-b39a-49ba-bd18-e0d5240cae06

📥 Commits

Reviewing files that changed from the base of the PR and between 9e7c687 and 540c9ea.

📒 Files selected for processing (6)
  • modules/ROOT/nav.adoc
  • modules/develop/pages/connect/components/inputs/salesforce.adoc
  • modules/develop/pages/connect/components/inputs/salesforce_cdc.adoc
  • modules/develop/pages/connect/components/inputs/salesforce_graphql.adoc
  • modules/develop/pages/connect/components/processors/salesforce.adoc
  • modules/get-started/pages/whats-new-cloud.adoc
💤 Files with no reviewable changes (1)
  • modules/develop/pages/connect/components/processors/salesforce.adoc

📝 Walkthrough

Walkthrough

This PR reclassifies Salesforce component documentation from the processor category to inputs. The changes add three new input component pages for Salesforce (standard, CDC, and GraphQL variants), update the navigation structure to reference these inputs and remove the processor reference, update the release notes to reflect the new component inventory, and remove the Salesforce processor page.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • redpanda-data/cloud-docs#346: Updates modules/ROOT/nav.adoc to add new Redpanda Connect inputs navigation entries and introduces corresponding component wrapper pages using single-source includes, similar pattern to this PR's Salesforce inputs additions.

Suggested reviewers

  • micheleRP
  • JakeSCahill
  • mfernest
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: replacing an orphan processor wrapper with three new input wrappers for Salesforce components.
Description check ✅ Passed The description is comprehensive and follows the template structure with Summary, Changes, Preview pages, and Test plan sections. However, the required fields from the template (issue link and checkboxes) are only partially completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-salesforce-orphan-processor-wrapper

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant