Fix search_model handling for dotted columns and query builders#1
Merged
AbdelrhmanSaid merged 1 commit intomasterfrom Apr 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
search_modelis called with a baseQueryBuilder(non-Eloquent) or when dotted columns reference no relation on the model.Description
search_modelreturn type toBuilder|QueryBuilderto match the accepted input signature insrc/helpers.php.Builder|QueryBuilderand added avoidreturn type.orWhereHasonly if the query is an EloquentBuilderand the relation method exists on the model; otherwise fall back to a plainorWhereon the column.src/helpers.phpand preserved original behavior for non-dotted columns.Testing
php -l src/helpers.phpand it reported no syntax errors (success)../vendor/bin/pint --test src/helpers.phpbut thepinttool is not installed in this environment (skipped).Codex Task