feat(schema): log warnings for removeField missing field and invalid HASH path#26
Open
linbo328 wants to merge 1 commit into
Open
feat(schema): log warnings for removeField missing field and invalid HASH path#26linbo328 wants to merge 1 commit into
linbo328 wants to merge 1 commit into
Conversation
…id path for HASH storage - Log warning with field name and known fields list when removeField is called with non-existent field - Log warning when path is provided for HASH storage type This helps diagnose typos in field names. Closes redis-developer#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented two warnings requested in the issue:
removeField: Logs a warning when the field is not found, including the field name and list of known fields.addField: Logs a warning when a path is provided for HASH storage type.Changes
src/schema/schema.ts: Replaced// TODO: log a warningcomments with actualconsole.warncalls.This helps users diagnose typos in field names when calling removeField.
Closes #13