feat(storage): implement geo field validation in BaseStorage.validateField#22
Open
HirenGajjar wants to merge 1 commit into
Open
feat(storage): implement geo field validation in BaseStorage.validateField#22HirenGajjar wants to merge 1 commit into
HirenGajjar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
What
Implements geo field validation in
BaseStorage.validateField, which previously had a TODO and silently accepted malformed values whenvalidateOnLoad: truewas set.Why
Malformed geo strings like
"foo,bar"were passing validation and getting rejected by Redis at index time, making debugging harder for users.Changes
longitude,latitudeformat[-180, 180]and latitudes outside[-90, 90]tests/unit/storage/covering all valid and invalid cases