Skip to content

docs: enforce #![deny(missing_docs)] and rustdoc::broken_intra_doc_links#98

Merged
joshrotenberg merged 1 commit into
mainfrom
docs/enforce-missing-docs-lint
May 19, 2026
Merged

docs: enforce #![deny(missing_docs)] and rustdoc::broken_intra_doc_links#98
joshrotenberg merged 1 commit into
mainfrom
docs/enforce-missing-docs-lint

Conversation

@joshrotenberg
Copy link
Copy Markdown
Contributor

Summary

All 368 missing-docs errors surfaced by the 2026-05 review are now closed across the cloud crate. This PR promotes the two lints to compile errors so the bar can't regress without a deliberate decision.

#![deny(missing_docs)]
#![deny(rustdoc::broken_intra_doc_links)]

How we got to zero

PR Slice Errors closed
#90 lib.rs stale-examples cleanup
#91 ConnectivityHandler delegation methods + fields 18
#92 types.rs: module header, all variants and fields 48
#93 Connectivity sub-module headers (psc / transit_gateway / vpc_peering)
#94 Small modules: account, acl, cloud_accounts, 3 connectivity sub-files 31
#95 users.rs field coverage 21
#96 Big request/response models: fixed/* + flexible/* (delegated mechanical pass) 249
#97 (issue) Follow-up filed on DatabaseBackupConfig field aliasing
This Enforce lints

cargo doc --no-deps -- -D missing_docs -D rustdoc::broken_intra_doc_links builds clean.

Test plan

  • cargo fmt --all -- --check
  • cargo doc --no-deps (now strict by default)
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace — 72 doctests + the rest, all pass

Closes #80

All 368 missing-docs errors surfaced by the 2026-05 review are now
closed across the cloud crate (#90, #91, #92, #93, #94, #95, #96).
This commit promotes those lints to compile errors so the bar
cannot regress without a deliberate decision.

- Adds #![deny(missing_docs)] to lib.rs — every public item must
  carry a docstring.
- Adds #![deny(rustdoc::broken_intra_doc_links)] — the intra-doc
  links added throughout the rustdoc pass (TaskStateUpdate ↔
  TaskStatus, ConnectivityHandler delegation pointers, etc.) stay
  valid going forward.

No source-level behavior changes. cargo fmt, cargo clippy
--workspace --all-targets -- -D warnings, cargo test --workspace,
and cargo doc --no-deps all pass.

Closes #80
@joshrotenberg joshrotenberg merged commit bbd0beb into main May 19, 2026
8 checks passed
@joshrotenberg joshrotenberg deleted the docs/enforce-missing-docs-lint branch May 19, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(rustdoc): add #![deny(missing_docs)] and fix 378 errors; add # Errors sections to handler methods

1 participant