Make 'APPROVED' new default for write and attachment access#477
Open
deseven wants to merge 1 commit intoredimp:mainfrom
Open
Make 'APPROVED' new default for write and attachment access#477deseven wants to merge 1 commit intoredimp:mainfrom
deseven wants to merge 1 commit intoredimp:mainfrom
Conversation
Owner
|
Thanks for the PR. As discussed, I think this is a useful change to the defaults: it prevents accidents while still allowing users to run wikis that can be edited anonymously. Will review in detail and merge in the next days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing previous security concerns, this makes
APPROVEDnew default forWRITE_ACCESSandATTACHMENT_ACCESS.This change broke a lot of tests, so I made some adjustments, adding a distinction between logged in and anonymous users where needed, so we test against our new default configuration instead of something that is more convenient. Any feedback on that is appreciated!