downstream fix: added mapping of timeout.reconciliation to env var#1048
Conversation
Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
Hi @alkakumari016. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
…t-imports Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
/test v4.19-kuttl-parallel |
Signed-off-by: Alka Kumari <alkumari@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit dd27508
into
redhat-developer:v1.18
…edhat-developer#1048) * downstream fix: added mapping of timeout.reconciliation to env var Signed-off-by: Alka Kumari <alkumari@redhat.com> * :fix(.golangci.yml): Configure staticcheck to ignore ginkgo/gomega dot-imports Signed-off-by: Alka Kumari <alkumari@redhat.com> * fixed panick error in ginkgo test Signed-off-by: Alka Kumari <alkumari@redhat.com> --------- Signed-off-by: Alka Kumari <alkumari@redhat.com>
2 participants
What type of PR is this?
kind bug
What does this PR do / why we need it:
downstream the fix for adding mapping for ARGOCD_RECONCILIATION_TIMEOUT env var from the configmap
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: