Adding message and chat HTML#100
Conversation
There was a problem hiding this comment.
Niceee @Yuval-Vino
don't forget to assign yourself, and add ready for review label,
and the most important tests are missing
Done! this PR is ready for reviews!! |
ErezCohenn
left a comment
There was a problem hiding this comment.
left some comments below, @Yuval-Vino take a look and tell me what you think
|
Please lint and re-orgenize |
thanks for the reviews, I address them all :) |
Done! also addressed all of your comments , let me know if you see more possible changes to improve |
OfirMatasas
left a comment
There was a problem hiding this comment.
Looks amazing! great job, @Yuval-Vino
tamirmatok
left a comment
There was a problem hiding this comment.
LGTM ! great job @Yuval-Vino .
ormergi
left a comment
There was a problem hiding this comment.
Hi Yuval, please squash intermediate commits
Done |
ormergi
left a comment
There was a problem hiding this comment.
Hi Yuval,
Please fix the commit message and body.
Also see my inline comments.
|
Please resolve conflicts ASAP if you want it in for the demo. |
author Yuval-Vino <99268065+Yuval-Vino@users.noreply.github.com>
fixed |
|
+1 LGTM |
Desired Outcome
Adding chat feature to Hotails
Implemented Changes
Added message and chat html
updated message views in order to fit the HTML files
updated navbar chat button to redirect to message HTML
updated hotails urls added message and chat htmls
updated function to daycare model - get_daycare_primary_image_url (as implemnted in #89 for showing daycare picture in chat)
also added CSS for the relevant htmls
Connected Issue/Story
Resolves #99
Changelog
CHANGELOG update
Test coverage
Added test for the HTML's that checking that we are in the right site
test_shown_only_relevant_contacts
test_shown_only_relevant_message_in_chat
test_send_new_message
test_cant_send_blank_message
Documentation
READMEs) were updated in this PRAdding pictures of the url
before picking specifc user to talk
after choosing chat (as a dogowner)
after choosing chat (as daycare)