feat: add IntersectionType support to PropertyCreateMockToCreateStubRector#661
Open
asumikam wants to merge 1 commit intorectorphp:mainfrom
Open
feat: add IntersectionType support to PropertyCreateMockToCreateStubRector#661asumikam wants to merge 1 commit intorectorphp:mainfrom
asumikam wants to merge 1 commit intorectorphp:mainfrom
Conversation
asumikam
force-pushed
the
feat/support-intersection-type
branch
from
1404d2c to
255f02e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables
PropertyCreateMockToCreateStubRectorto correctly handleIntersectionType(e.g.,MockObject&\stdClass).Motivation
Thank you for the continuous development of Rector.
While using this Rector in my own project for migration, I noticed that property types were not being handled correctly when they contained intersection types.
I have verified that this change allows for a clean migration in my project's codebase.
Changes
Previously, the rector unconditionally replaced the property type with
FullyQualified(PHPUnitClassName::STUB), which broke intersection types. This PR introduces anupdatePropertyType()method to handle two specific cases:MockObjectwithStubwhile preserving the other members (e.g.,MockObject&\stdClass→Stub&\stdClass).Please let me know if there are any edge cases I might have missed or if further adjustments are needed.
Thank you for your time and review!