Skip to content

fix(sandbox): bump @vercel/sandbox to v2 — production incident #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweetmantech merged 1 commit into from
May 4, 2026
Merged

fix(sandbox): bump @vercel/sandbox to v2 — production incident #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dependencies": {
"@fal-ai/client": "^1.9.4",
"@trigger.dev/sdk": "4.3.3",
"@vercel/sandbox": "^1.8.0",
"@vercel/sandbox": "2.0.0-beta.11",
"ai": "^6.0.143",
"ms": "^2.1.3",
"trigger.dev": "4.3.3",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/sandboxes/__tests__/getOrCreateSandbox.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ vi.mock("@trigger.dev/sdk/v3", () => ({
vi.mock("@vercel/sandbox", () => ({
Sandbox: {
get: vi.fn().mockResolvedValue({
sandboxId: "sbx_123",
name: "sbx_123",
status: "running",
}),
},
Expand Down Expand Up @@ -53,7 +53,7 @@ describe("getOrCreateSandbox", () => {
await getOrCreateSandbox("acc_1");

expect(Sandbox.get).toHaveBeenCalledWith(
expect.objectContaining({ sandboxId: "sbx_123" }),
expect.objectContaining({ name: "sbx_123" }),
);
});

Expand All @@ -62,7 +62,7 @@ describe("getOrCreateSandbox", () => {

expect(result.sandboxId).toBe("sbx_123");
expect(result.sandbox).toEqual(
expect.objectContaining({ sandboxId: "sbx_123" }),
expect.objectContaining({ name: "sbx_123" }),
);
});

Expand Down
2 changes: 1 addition & 1 deletion src/sandboxes/getOrCreateSandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export async function getOrCreateSandbox(
}

const sandbox = await Sandbox.get({
sandboxId: created.sandboxId,
name: created.sandboxId,
token,
teamId,
projectId,
Expand Down
2 changes: 1 addition & 1 deletion src/tasks/codingAgentTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const codingAgentTask = schemaTask({

return { branch, snapshotId, prs, stdout: agentResult.stdout, stderr: agentResult.stderr };
} finally {
logStep("Stopping sandbox", false, { sandboxId: sandbox.sandboxId });
logStep("Stopping sandbox", false, { sandboxId: sandbox.name });
await sandbox.stop();
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/tasks/runSandboxCommandTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const runSandboxCommandTask = schemaTask({
accountId,
});

const sandbox = await Sandbox.get({ sandboxId, token, teamId, projectId });
const sandbox = await Sandbox.get({ name: sandboxId, token, teamId, projectId });

logStep("Connected to sandbox");

Expand Down
4 changes: 2 additions & 2 deletions src/tasks/setupSandboxTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const setupSandboxTask = schemaTask({
);

logStep("Sandbox setup complete", true, {
sandboxId: sandbox.sandboxId,
sandboxId: sandbox.name,
githubRepo: githubRepo ?? null,
snapshotId: snapshotResult.snapshotId,
});
Expand All @@ -47,7 +47,7 @@ export const setupSandboxTask = schemaTask({
snapshotId: snapshotResult.snapshotId,
};
} finally {
logStep("Stopping sandbox", false, { sandboxId: sandbox.sandboxId });
logStep("Stopping sandbox", false, { sandboxId: sandbox.name });
await sandbox.stop();
}
},
Expand Down
4 changes: 2 additions & 2 deletions src/tasks/updatePRTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const updatePRTask = schemaTask({
timeout: 30 * 60 * 1000,
});

logStep("Sandbox resumed", false, { sandboxId: sandbox.sandboxId, snapshotId });
logStep("Sandbox resumed", false, { sandboxId: sandbox.name, snapshotId });

try {
await configureGitAuth(sandbox);
Expand Down Expand Up @@ -83,7 +83,7 @@ export const updatePRTask = schemaTask({

return { snapshotId: newSnapshot.snapshotId };
} finally {
logStep("Stopping sandbox", false, { sandboxId: sandbox.sandboxId });
logStep("Stopping sandbox", false, { sandboxId: sandbox.name });
await sandbox.stop();
}
},
Expand Down
Loading