Skip to content

feat(tasks): migrate GET /api/artists/pro#146

Merged
sweetmantech merged 2 commits intomainfrom
feat/migrate-get-api-artists-pro
Apr 24, 2026
Merged

feat(tasks): migrate GET /api/artists/pro#146
sweetmantech merged 2 commits intomainfrom
feat/migrate-get-api-artists-pro

Conversation

@arpitgupta1214
Copy link
Copy Markdown
Collaborator

@arpitgupta1214 arpitgupta1214 commented Apr 23, 2026

Cuts getProArtists over to ${NEW_API_BASE_URL}/api/artists/pro with x-api-key: RECOUP_API_KEY auth. Response schema unchanged.

Test plan

  • pnpm test passes (350/350)
  • grep "api.recoupable.com/api/artists/pro" in tasks/ returns zero hits
  • Post-merge: first scheduled run of pro-artist-social-profiles-scrape at midnight ET completes with totalArtists > 0 (Trigger.dev logs)
  • Tasks service account (owner of RECOUP_API_KEY) flagged admin before merge so the new route's admin-scope gate does not 403

Summary by cubic

Migrates getProArtists to ${NEW_API_BASE_URL}/api/admins/artists/pro and authenticates via x-api-key using RECOUP_API_KEY. Response schema is unchanged; adds a guard that logs and returns undefined if RECOUP_API_KEY is missing.

Written for commit 7f17787. Summary will update on new commits.

Cuts getProArtists over to `${NEW_API_BASE_URL}/api/artists/pro` with
`x-api-key: RECOUP_API_KEY` auth. Response schema unchanged.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@arpitgupta1214 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 13 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 13 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83731212-0a92-4884-acaa-b57d2fe7bb22

📥 Commits

Reviewing files that changed from the base of the PR and between 242d1b5 and 7f17787.

📒 Files selected for processing (1)
  • src/recoup/getProArtists.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/migrate-get-api-artists-pro

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/recoup/getProArtists.ts">

<violation number="1" location="src/recoup/getProArtists.ts:16">
P2: Custom agent: **Flag AI Slop and Fabricated Changes**

Implemented route does not match the PR’s stated migration target, indicating a fabricated or inaccurate change claim.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

return undefined;
}

const url = `${NEW_API_BASE_URL}/api/admins/artists/pro`;
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Custom agent: Flag AI Slop and Fabricated Changes

Implemented route does not match the PR’s stated migration target, indicating a fabricated or inaccurate change claim.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/recoup/getProArtists.ts, line 16:

<comment>Implemented route does not match the PR’s stated migration target, indicating a fabricated or inaccurate change claim.</comment>

<file context>
@@ -13,7 +13,7 @@ export async function getProArtists(): Promise<string[] | undefined> {
   }
 
-  const url = `${NEW_API_BASE_URL}/api/artists/pro`;
+  const url = `${NEW_API_BASE_URL}/api/admins/artists/pro`;
 
   try {
</file context>
Fix with Cubic

@sweetmantech sweetmantech merged commit f9a0d2a into main Apr 24, 2026
3 checks passed
@sweetmantech sweetmantech deleted the feat/migrate-get-api-artists-pro branch April 24, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants