Skip to content

feat: add dsp logo overlay to content pipeline (REC-63)#135

Open
recoup-coding-agent wants to merge 1 commit intomainfrom
feature/rec-63-dsp-logo
Open

feat: add dsp logo overlay to content pipeline (REC-63)#135
recoup-coding-agent wants to merge 1 commit intomainfrom
feature/rec-63-dsp-logo

Conversation

@recoup-coding-agent
Copy link
Copy Markdown
Collaborator

@recoup-coding-agent recoup-coding-agent commented Apr 14, 2026

Summary

  • Add dsp field to createContentPayloadSchema with DSP_VALUES enum
  • New resolveDspLogoUrl utility maps dsp value to placeholder logo URL
  • createContentTask appends DSP logo URL to overlay images for ffmpeg render
  • 5 new tests for DSP resolution and pipeline integration

Test plan

  • resolveDspLogoUrl returns null for none, URLs for spotify/apple
  • Pipeline includes DSP logo in overlay URLs when dsp is set
  • Pipeline omits DSP logo when dsp is none
  • All 350 existing tasks tests still pass

🤖 Generated with Claude Code


Summary by cubic

Adds an optional DSP logo overlay to the content pipeline. When dsp is spotify or apple, the logo is included in the final ffmpeg render; none keeps current behavior. Implements REC-63.

  • New Features
    • Adds dsp to createContentPayloadSchema (none | spotify | apple, default none).
    • Introduces resolveDspLogoUrl to map DSP to hosted logo URLs.
    • Appends the logo to overlayImageUrls in createContentTask (works whether or not the template uses image overlays).
    • Adds tests for DSP URL resolution and pipeline integration.

Written for commit fe3784d. Summary will update on new commits.

Add DSP logo support to the video rendering pipeline. When a dsp
value ("spotify" or "apple") is provided, the corresponding logo
URL is appended to overlay images for the final ffmpeg render.

- Add DSP_VALUES and dsp field to content creation schema
- Add resolveDspLogoUrl utility with placeholder URLs
- Integrate DSP logo into createContentTask overlay logic
- Add 5 new tests for DSP resolution and pipeline integration

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@recoup-coding-agent has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 36 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 36 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6a1212f3-3c60-4c0b-836a-977bef5b3ae3

📥 Commits

Reviewing files that changed from the base of the PR and between ddf9404 and fe3784d.

📒 Files selected for processing (5)
  • src/content/__tests__/resolveDspLogoUrl.test.ts
  • src/content/resolveDspLogoUrl.ts
  • src/schemas/contentCreationSchema.ts
  • src/tasks/__tests__/createContentTask.test.ts
  • src/tasks/createContentTask.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/rec-63-dsp-logo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant