chore: delete dead auth/github stub routes#27
Conversation
These three routes were leftovers from the Better Auth + linked-accounts flow ripped out in PR #26 (db unification). All three only redirect, and their redirect targets do not exist: - auth/github/callback -> redirects to "/" (no real callback work) - auth/signin/github -> /api/auth/signin/vercel (404 — route gone) - auth/github/reconnect -> /api/github/app/install (404 — never built) Nothing in the app links to them, the GitHub OAuth flow they served has been replaced by Privy, and the reconnect test was asserting a redirect into a non-existent install route — so the test goes too. First step of porting open-agents' /api folder into the api codebase (Phase A of the open-agents-into-chat consolidation). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughDeleted four GitHub authentication API routes and their test file: callback handler, reconnect flow with redirect sanitization, and signin redirect route. No replacement implementations provided. ChangesGitHub Authentication Route Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 4 files
You're on the cubic free plan with 19 free PR reviews remaining this month. Upgrade for unlimited reviews.
Summary
app/api/auth/github/*andapp/api/auth/signin/githubroute handlersauth/github/callback→/auth/signin/github→/api/auth/signin/vercel(404)auth/github/reconnect→/api/github/app/install(404)This is Phase A of the open-agents
/api/→apicodebase migration (overall direction: api owns all backend, open-agents UI calls api over Privy Bearer; later folded into chat).Test plan
bun run --cwd apps/web typecheckpasses (no callers)bun run checkpasses (no lint/format issues)auth/github,auth/signin/github,github_reconnect,/api/github/app/install— zero hits outside the deleted files/sessionsstill loads for an authenticated user🤖 Generated with Claude Code
Summary by cubic
Removed dead GitHub auth routes
apps/web/app/api/auth/github/{callback,reconnect}andapps/web/app/api/auth/signin/github, plus the reconnect test. They only redirected to missing endpoints and are obsolete after the Privy auth flow; this is Phase A of moving open-agents/api/into theapicodebase.Written for commit 7bb1053. Summary will update on new commits.
Summary by CodeRabbit
Revert
Tests