docs(docs): add PATCH /api/artists/{id}#129
Conversation
📝 WalkthroughWalkthroughAdded a new API reference page and registered it in navigation, plus extended the OpenAPI spec with a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="api-reference/openapi/releases.json">
<violation number="1" location="api-reference/openapi/releases.json:3403">
P2: The `missing_fields` description says "Path to the first invalid field" (singular) but the type is an `array` of strings. Align with the existing `CreateArtistError` schema which uses "List of missing or invalid field names", or clarify that the array represents path segments.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
…ndpoints # Conflicts: # docs.json
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| title: 'Update Artist' | |||
| description: 'Update manual artist settings for an artist accessible to the authenticated account.' | |||
There was a problem hiding this comment.
KISS principle. Don't mention auth in the initial API description. Keep it simple for devs and LLMs to answer the question: Why would I use this endpoint?.
There was a problem hiding this comment.
| description: 'Update manual artist settings for an artist accessible to the authenticated account.' | |
| description: 'Update the settings for an artist.' |
| }, | ||
| "/api/artists/{id}": { | ||
| "patch": { | ||
| "description": "Update manual artist settings for an artist accessible to the authenticated account. This updates profile fields, artist account info, and any provided socials, then returns the merged artist payload.", |
There was a problem hiding this comment.
Same KISS feedback. Auth is always implied in Recoup API. No need to redundantly state it on each specific endpoint.
| "description": "Update manual artist settings for an artist accessible to the authenticated account. This updates profile fields, artist account info, and any provided socials, then returns the merged artist payload.", | |
| "description": "Update an artist's settings. This updates profile fields, artist account info, and any provided socials, then returns the merged artist payload.", |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@api-reference/openapi/releases.json`:
- Around line 3570-3576: The schema for missing_fields currently declares an
array but the description says "Path to the first invalid field," causing
ambiguity; update the description of missing_fields (the array with "items":
{"type":"string"}) to accurately describe that it contains one or more field
path strings (e.g., "Paths to missing or invalid fields, each as a dot-separated
string") so clients/docs understand it's an array of field path strings, or
alternatively change the type to "string" if you intend a single path—adjust
only the description or the type accordingly on the missing_fields schema.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d3c4bdee-ad49-4a7d-9b6d-f49f4491039e
📒 Files selected for processing (3)
api-reference/artists/update.mdxapi-reference/openapi/releases.jsondocs.json
- Document pinned in UpdateArtistRequest and PATCH description so the endpoint reflects the pin/unpin consolidation in api. - Drop "authenticated account" phrasing per KISS review feedback; auth is implied for every Recoup endpoint. - Clarify missing_fields description on UpdateArtistErrorResponse to match CreateArtistError phrasing.
Pin state is documented as a body field; descriptions stay focused on the endpoint's purpose.
Summary
PATCH /api/artists/{id}in releases OpenAPI.Notes
Summary by CodeRabbit
New Features
Documentation