[nit] GADTs: add #require directives for abstracting code listings#3680
Open
dijkstracula wants to merge 1 commit intorealworldocaml:masterfrom
Open
[nit] GADTs: add #require directives for abstracting code listings#3680dijkstracula wants to merge 1 commit intorealworldocaml:masterfrom
abstracting code listings#3680dijkstracula wants to merge 1 commit intorealworldocaml:masterfrom
Conversation
…achines' listings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the GADT chapter, the
sum_file_sizescode makes use ofSys_unix.ls_dirandCore_unix.lstat. However, those modules are unbound for readers who are following along in the REPL.This patch simply adds a code listing
#requireing them, and removes the TODO indicating that there perhaps ought to be such a code listing.Thank you for an enjoyable book.