Open
Conversation
- `python-pygments` is now `python3-pygments` - There was no `depext` Makefile target, as referenced in the README. Point it to the Docker target, which builds the image including dependencies. - Separate building the Docker container from building the documentation. - Don't copy the book source into the container. Volume mount it, instead. This saves having to rebuild the container when rebuilding the book. - Add a Docker bash target, giving you an interactive terminal in the (volume-mounted) container, in case you need to manually experiment.
…e file somewhere, but I don't know done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instructions in the
readmefor installing the dependencies to build the book seem incorrect. There is nodepexttarget, but based on what is there, I think it's safe to assume that the Docker target is the one that lines up the build dependencies. But the Dockerfile both accumulates dependencies and builds the book, which isn't right, so I separated those into two discrete Makefile targets.A lot of this backsolves the intent of how it should work from what's present in the project. It makes a few assumptions. Feel free to decline if this doesn't align with the actual intent of how the build should work.
The second commit adds an epub target, which was my original intent behind all this — to get a variant of the book to read on an eInk device. There's probably a better way to do this step, using Dune, but I don't yet know Dune or OCaml. Feel free to discard that second commit or refactor it to something more dune-like.