Replace SwiftSoup with regex-based attribute lookup in Readium CSS injection#742
Merged
mickael-menu merged 6 commits intodevelopfrom Apr 2, 2026
Merged
Replace SwiftSoup with regex-based attribute lookup in Readium CSS injection#742mickael-menu merged 6 commits intodevelopfrom
mickael-menu merged 6 commits intodevelopfrom
Conversation
Contributor
|
I know it has nothing to do with this PR, but could you change the carthage project in the Makefile? |
Member
Author
|
I won't merge this PR quickly, I want to do more regression testing on it. But we can open a PR with just this change in the |
…wiftsoup-readiumcss
mickael-menu
force-pushed
the
fix/swiftsoup-readiumcss
branch
from
2dabdc7 to
9cfdbe8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mickael-menu
force-pushed
the
fix/swiftsoup-readiumcss
branch
from
262899d to
9cfdbe8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mickael-menu
force-pushed
the
fix/swiftsoup-readiumcss
branch
from
2409a05 to
617b5a6
Compare
darktasevski
added a commit
to darktasevski/swift-toolkit
that referenced
this pull request
Apr 9, 2026
* upstream/develop: Fix decoration positions with paragraph indent (readium#767) Replace SwiftSoup with regex-based attribute lookup in Readium CSS injection (readium#742) Add support for SVG covers (readium#751) Fix race condition when applying EPUB decorations (readium#765) Add slide animation for adjacent EPUB resource transitions (readium#763) Remove unavailable APIs (readium#759) Remove Carthage support (readium#760) Improve `DirectionalNavigationAdapter` (readium#757) Update JSON usage from `Any` to `JSONValue` (readium#740) Fix LCP-enabled TestApp (readium#754) Report continuous `totalProgression` in the EPUB locator (readium#753) Document device name behavior for LCP registration (readium#752) Fix screen flashes during unanimated page turns in the EPUB navigator (readium#750) Fix parsing of URI templates (readium#749) Fix EPUB contributor role parsing (readium#748) Introduce the Readium Swift Playground (readium#746) # Conflicts: # Sources/Navigator/EPUB/Assets/Static/scripts/readium-fixed.js # Sources/Navigator/EPUB/Assets/Static/scripts/readium-reflowable.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Readium CSS injection pipeline previously used SwiftSoup to parse the full HTML document just to read
lang/xml:langattributes on<html>and<body>. This replaces that with lightweight regex lookups on the raw HTML string, using the existingHTMLElementinfrastructure.