Conversation
jgriss
left a comment
There was a problem hiding this comment.
While this PR contains the required changes in the API "frontend", the support in the analysis code is still missing.
|
@jgriss How is the analysis code affected? |
EliotRagueneau
left a comment
There was a problem hiding this comment.
Looking good to me, but Johannes will know better if something is missing
| description="Single-cell RNA-seq data of B cells extracted from the Jerby-Arnon at al. study (Cell 2018).", | ||
| group="SC_EXAMPLES"), | ||
| ExternalData(id="EXAMPLE_METABOLOMICS", title="Liver cirrhosis metabolomics example", type="metabolomics", | ||
| description="MTBLS5665: Transcriptomic and metabolomic analysis of liver cirrhosis", |
There was a problem hiding this comment.
Maybe it would be better to not start the description with the identifier. It should follow the same structure as other example definitions in my opinion. (Not a bad idea to add the dientifier though, but maybe more at the end, it's more inviting to read)
|
About the analysis code:
|
|
One additional important note: Need to check whether this requires different internal mapping files (currently UniProt and ENSEMBL are directly supported) |
No description provided.