Update README.md#190
Merged
Merged
Conversation
|
These are called hooks and they can run before or after the script, depending on the prefix: Can you run |
|
I had the same issue when I recently installed the repo as well. I had to spent time figuring the same thing out. I propose merging this change. I've just noticed that for the last 10 months, ignoring scripts is true for everyone. See https://github.com/facebook/react-native-devtools-frontend/blob/main/.npmrc shows |
hoxyq
approved these changes
Jul 11, 2025
I had to run `npm run prebuild` to setup `build.ninja` in the out dir. Without it I wasn't able to run any of the other build options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to run
npm run prebuildto setupbuild.ninjainout/Default. Without it I wasn't able to run any of the other build options.Summary
Following the readme, I was running into this error
After running prebuild,
out/Defaultwas setup correctly. Adding that step to the readme.Test plan
Fresh clone
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.