feat: Support required arguments in CLI commands#2658
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
robhogan
commented
May 7, 2025
| '--optional-arg', | ||
| 'foo', | ||
| ]); | ||
| expect(stdout).toBe('test-command-ts'); |
Collaborator
Author
There was a problem hiding this comment.
These tests are broken - working on it - don't merge ;)
7210bd5 to
250b936
Compare
250b936 to
4c192ab
Compare
Collaborator
Author
Member
|
We need to rethink these e2e tests. Currently they’re installing whole new project and cocoa pods for each case which takes too much time. I’m good with marking some as test.todo because this CI is red for too long |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
While doing some work on
react-native bundleI noticed some arguments we require are actually notrequiredOptions in Commander, and I was surprised that there was no way to mark an option required in config.This adds the
requiredfield toCommandOptionand passes it through so that we can more easily validate and emit user-actionable errors.Test Plan
Made these changes locally (with
link) against RN 0.80-rc.0, and tested by addingrequiredto thebundlecommand:Before
path.dirname(undefined)After
Checklist
react-nativecheckout (instructions).NOTE: e2e tests are hanging for me so I wasn't able to validate the new tests