fix: Reduce the required props for ResizableBox#264
Conversation
* The only required props for ResizableBox should be height, width, and children. Previously the keys from DefaultProps were required as well.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR fixes a TypeScript type issue in react-resizable where DefaultProps fields were incorrectly marked as required, even though they all have runtime defaults. The Props type is now wrapped in ChangesProps Type Relaxation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
closes: #263
Summary by CodeRabbit
New Features
Tests