fix: skip flushInputValue and onPressEnter during IME composition#731
fix: skip flushInputValue and onPressEnter during IME composition#731Hualalala741 wants to merge 1 commit intoreact-component:masterfrom
Conversation
|
@Hualalala741 is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
概述优化了 变更
建议的审阅者
预估代码审阅工作量🎯 2 (Simple) | ⏱️ ~12 分钟 诗
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Code Review
This pull request modifies the InputNumber component to prevent triggering onPressEnter and flushing the input value when the Enter key is pressed during IME composition. It also adds comprehensive unit tests to verify this behavior and ensure that these actions only occur after composition has ended. I have no feedback to provide.
composition 未结束前不应执行 flushInputValue 和 onPressEnter,否则受控value会与输入框不同步。
Summary by CodeRabbit
发布说明
Bug Fixes
Tests