Cursor animations not working on oculus#55
Open
levexis wants to merge 3 commits intordub80:masterfrom
Open
Conversation
Implement text update on button component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor animations were not working on Oculus. Getting a lot of errors from threejs about faceless geometry. Changed calls to threejs animation to use a-frame animation component. Changed calls to a-frame utils to just use element setComponent. Tested in chrome, IE and on oculus quest 2.
This also has the text update PR from jfilipedias merged in as I needed that fix for my UI to work.