add npm overrides for three-mesh-bvh and meshoptimiz#183
Closed
goyaljiiiiii wants to merge 2 commits into
Closed
Conversation
…er to resolve deprecation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend’s npm dependency resolution to address deprecated three.js ecosystem transitive dependencies (Issue #182) by introducing overrides and regenerating the lockfile.
Changes:
- Added npm
overridesto force newer versions ofthree-mesh-bvhandmeshoptimizer. - Regenerated
package-lock.json, updating resolved versions for multiple dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RestroHub-FrontEnd/package.json | Adds overrides to force newer 3D-related transitive dependency versions. |
| RestroHub-FrontEnd/package-lock.json | Refreshes lockfile to reflect overrides and updated dependency resolution. |
Files not reviewed (1)
- RestroHub-FrontEnd/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
27
| "react-hot-toast": "^2.6.0", | ||
| "react-icons": "^5.5.0", | ||
| "react-qr-code": "^2.0.18", | ||
| "react-router-dom": "^7.13.0", | ||
| "react-router-dom": "^6.30.1", | ||
| "recharts": "^3.7.0", |
Comment on lines
2135
to
2151
| "node_modules/@vitejs/plugin-react": { | ||
| "version": "4.7.0", | ||
| "resolved": "https://registry.npmjs.org/@vitejs/plugin-react/-/plugin-react-4.7.0.tgz", | ||
| "integrity": "sha512-gUu9hwfWvvEDBBmgtAowQCojwZmJ5mcLn3aufeCsitijs3+f2NsrPtlAWIR6OPiqljl96GVCUbLe0HyqIpVaoA==", | ||
| "version": "5.2.0", | ||
| "resolved": "https://registry.npmjs.org/@vitejs/plugin-react/-/plugin-react-5.2.0.tgz", | ||
| "integrity": "sha512-YmKkfhOAi3wsB1PhJq5Scj3GXMn3WvtQ/JC0xoopuHoXSdmtdStOpFrYaT1kie2YgFBcIe64ROzMYRjCrYOdYw==", | ||
| "dev": true, | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@babel/core": "^7.28.0", | ||
| "@babel/core": "^7.29.0", | ||
| "@babel/plugin-transform-react-jsx-self": "^7.27.1", | ||
| "@babel/plugin-transform-react-jsx-source": "^7.27.1", | ||
| "@rolldown/pluginutils": "1.0.0-beta.27", | ||
| "@rolldown/pluginutils": "1.0.0-rc.3", | ||
| "@types/babel__core": "^7.20.5", | ||
| "react-refresh": "^0.17.0" | ||
| "react-refresh": "^0.18.0" | ||
| }, | ||
| "engines": { | ||
| "node": "^14.18.0 || >=16.0.0" | ||
| "node": "^20.19.0 || >=22.12.0" | ||
| }, |
Owner
|
Hi @goyaljiiiiii , |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
Hey @rdodiya fixed |
Owner
|
Hi @goyaljiiiiii , |
Owner
|
Closing this , please update this changes under #185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds npm overrides to the frontend to force newer, non-deprecated versions of 3D-related transitive deps and refreshes the lockfile.
What I changed
Files: package.json:1-200, package-lock.json:1-20
Change: Added an overrides section to force:
three-mesh-bvh -> ^0.9.10
meshoptimizer -> ^1.1.1
Ran npm install to regenerate the lockfile.
Testing checklist for reviewers
npm install completes without the previous three.js deprecation warnings.
npm audit shows the three/mesh deprecation issue resolved (and fewer related advisories).
npm run dev loads the app at http://localhost:3000, and pages using three/drei render without errors in the browser console.
Smoke-test login, menu, and admin dashboard flows.
Author: @goyaljiiiiii
Reference issue #182