Skip to content

Fix buffer overflow in Vlan_SetMacAddr from int/ULONG type mismatch #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix buffer overflow in Vlan_SetMacAddr from int/ULONG type mismatch #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6e2669
Initial plan
Copilot Nov 19, 2025
1f2421f
Fix buffer overflow in Vlan_SetMacAddr by correcting type mismatch
Copilot Nov 19, 2025
e4ebddf
Remove unnecessary auto-generated build files
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/TR-181/middle_layer_src/vlan_apis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ static ANSC_STATUS Vlan_SetMacAddr( PDML_VLAN pEntry )
char hex[32];
char macStr[32];
int i, j = 0;
int add = 0;
ULONG add = 0;


if(NULL == pEntry)
Expand All @@ -488,7 +488,7 @@ static ANSC_STATUS Vlan_SetMacAddr( PDML_VLAN pEntry )
acTmpReturnValue[j] = '\0';
sscanf(acTmpReturnValue, "%64llx", &number);

if (Vlan_GetEthLinkMacOffSet(pEntry, (PULONG)&add) == ANSC_STATUS_FAILURE)
if (Vlan_GetEthLinkMacOffSet(pEntry, &add) == ANSC_STATUS_FAILURE)
{
CcspTraceError(("%s - Failed to set Enable data model\n", __FUNCTION__));
return ANSC_STATUS_FAILURE;
Expand Down
Loading