CBR2-2262 : set primary_lan_l3net sysevent#302
Open
rajkamal-cv wants to merge 1 commit intodevelopfrom
Open
Conversation
Reason for change: Fix the typo in setting primary_lan_l3net sysevent Test Procedure: Flash the image and test the brlan0 in CBR2 Risks: Low Priority: P1
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a typo in the LAN initialization handler intended to ensure the primary_lan_l3net sysevent is set correctly for CBR2/TCCBR scenarios.
Changes:
- Replace an invalid
syseveninvocation withsysevent set primary_lan_l3net 4. - Replace a no-op
echo(redirected to/dev/null) with anecho_tlog message in the same branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
439
to
443
| elif [ "$BOX_TYPE" = "TCCBR" ]; then | ||
| if [ -z "$INST" ]; then | ||
| echo "*****SET THE PRIMARY LAN ******" > /dev/null | ||
| syseven set primary_lan_l3net 4 | ||
| echo_t "SET THE PRIMARY LAN $INST" | ||
| sysevent set primary_lan_l3net 4 | ||
| fi |
| if [ -z "$INST" ]; then | ||
| echo "*****SET THE PRIMARY LAN ******" > /dev/null | ||
| syseven set primary_lan_l3net 4 | ||
| echo_t "SET THE PRIMARY LAN $INST" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fix the typo in setting primary_lan_l3net sysevent
Test Procedure: Flash the image and test the brlan0 in CBR2
Risks: Low
Priority: P1