RDKB-62887: Changing frequent logs to debug#27
Open
jayasrikadiyal wants to merge 2 commits into
Open
Conversation
Reason for change: Modifying log to Debug. Test Procedure: Tested by modfying log levl to Debug. Risks: Low Priority:P2 Signed-off-by:jayasri_kadiyala@comcast.com
There was a problem hiding this comment.
Pull request overview
This PR reduces selected SNMP-related log verbosity by changing frequent informational/warning traces to debug-level traces, and adds an ansc_platform.h include where CcspTraceDebug is now used.
Changes:
- Converts SNMP GET call/success logs from info to debug.
- Converts cache registration success logs from info to debug.
- Converts several CCSP component-resolution failure logs from warning to debug.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
source/SnmpPlugin/cosa_api.c |
Demotes SNMP GET call/success logs to debug. |
source/SnmpPlugin/ccsp_table_helper_control.c |
Demotes table cache registration success log to debug. |
source/SnmpPlugin/ccsp_table_helper_access.c |
Demotes table cache component-resolution failure log to debug. |
source/SnmpPlugin/ccsp_scalar_helper_control.c |
Demotes scalar cache registration success log to debug. |
source/SnmpPlugin/ccsp_scalar_helper_access.c |
Demotes scalar cache component-resolution failure log to debug. |
source/SnmpPlugin/ccsp_mib_utilities.c |
Demotes filter namespace component-resolution failure log to debug. |
source/custom/ccsp_snmp_common.c |
Adds ansc_platform.h and demotes get/set DM component-resolution failures to debug. |
Comments suppressed due to low confidence (1)
source/custom/ccsp_snmp_common.c:114
- When
set_dm_valuecannot resolve the destination component it now returns-1with no warning-level diagnostic from this helper. The generic caller only sees a failed set, so demoting the component-resolution failure to debug makes production troubleshooting harder for failed SNMP writes.
CcspTraceDebug(("Failed to find the CCSP component who supports '%s'\n", param));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if( !Cosa_FindDestComp(pDMString, &pThisObject->pCcspComp, &pThisObject->pCcspPath) ) | ||
| { | ||
| AnscTraceWarning(("Failed to find the CCSP component who supports '%s'\n", pDMString)); | ||
| CcspTraceDebug(("Failed to find the CCSP component who supports '%s'\n", pDMString)); |
| if( !Cosa_FindDestComp(pDMString, &pThisObject->pCcspComp, &pThisObject->pCcspPath) ) | ||
| { | ||
| AnscTraceWarning(("Failed to find the CCSP component who supports '%s'\n", pDMString)); | ||
| CcspTraceDebug(("Failed to find the CCSP component who supports '%s'\n", pDMString)); |
| //Get Destination component | ||
| if(!Cosa_FindDestComp((char *)param, &ppDestComponentName, &ppDestPath)){ | ||
| AnscTraceWarning(("Failed to find the CCSP component who supports '%s'\n", param)); | ||
| CcspTraceDebug(("Failed to find the CCSP component who supports '%s'\n", param)); |
| if( !Cosa_FindDestComp(pBuffer, ppDestName, ppDestPath) || *ppDestName == NULL || *ppDestPath == NULL) | ||
| { | ||
| AnscTraceWarning(("Failed to find the CCSP component who supports '%s'\n", pBuffer)); | ||
| CcspTraceDebug(("Failed to find the CCSP component who supports '%s'\n", pBuffer)); |
Reason for change: Modifying log to Debug. Test Procedure: Tested by modfying log levl to Debug. Risks: Low Priority:P2 Signed-off-by:jayasri_kadiyala@comcast.com
GoutamD2905
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Modifying log to Debug.
Test Procedure: Tested by modfying log levl to Debug.
Adding screenshot of logs.
Risks: Low
Priority:P2
Signed-off-by:jayasri_kadiyala@comcast.com