Resoving UT failures#24
Open
Nithishkumar-T wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the unit-test runner to use the GitHub-hosted gmock-broadband dependency and to build/run discovered gtest binaries generically instead of invoking a single fixed test binary. It fits into the repo’s CI path by changing how source/test/run_ut.sh prepares dependencies and executes UTs.
Changes:
- Switches
RdkbGMockcheckout/fetch logic from Gerrit change refs to GitHubdevelop/PR refs. - Replaces the single
make -C source/test+snmp_subagent_gtest.binexecution path with a generic loop over discoveredMakefiledirectories and.binexecutables. - Cleans up header/license text and minor log-message formatting in the UT script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+140
to
+141
| "$bin_file" | ||
| log "INFO" "Completed Test Execution for $(basename "$bin_file")" |
| else | ||
| log "INFO" "No change number/revision provided, skipping git fetch and cherry-pick." | ||
| log "INFO" "No PR ID provided. Fetching latest from branch: develop" | ||
| if git fetch "https://github.com/rdkcentral/gmock-broadband.git" develop && git checkout develop; then |
Comment on lines
+142
to
+143
| else | ||
| log "ERROR" "$(basename "$bin_file") is not executable, skipping" |
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.