RDKB-62887: To reduce logging in SNMP module#23
Closed
jayasrikadiyal wants to merge 6 commits into
Closed
Conversation
Reason for change: To fix the issue. Test Procedure: Tested on RG Risks: Low Priority:P2 Signed-off-by:jayasrikadiyala@gmail.com
Reason for change: To fix the issue. Test Procedure: Tested on RG Risks: Low Priority:P2 Signed-off-by:jayasrikadiyala@gmail.com
Reason for change: To fix the issue. Test Procedure: Tested on RG Risks: Low Priority:P2 Signed-off-by:jayasrikadiyala@gmail.com
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit 21dbb45.
There was a problem hiding this comment.
Pull request overview
This PR addresses RDKB-62887 by reducing SNMP component log verbosity, primarily by downgrading several Info/Warning trace points to Debug-level equivalents and adding a local debug trace helper.
Changes:
- Added
ccsp_snmp_debug.hto provide anAnscTraceDebugmacro for SNMP sources. - Replaced selected
AnscTraceInfo/AnscTraceWarningcalls withAnscTraceDebugin table/scalar helper and common DM access paths. - Replaced selected
CcspTraceInfocalls withCcspTraceDebugin SNMP GET parameter handling.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/include/ccsp_snmp_debug.h | Adds a debug macro intended to support lowering ANSC trace verbosity. |
| source/custom/ccsp_snmp_common.c | Lowers “find destination component” logging from Warning to Debug. |
| source/SnmpPlugin/cosa_api.c | Lowers SNMP GET “called/success” logs from Info to Debug. |
| source/SnmpPlugin/ccsp_table_helper_control.c | Lowers cache-handler registration log from Info to Debug and includes new debug header. |
| source/SnmpPlugin/ccsp_table_helper_access.c | Lowers “find destination component” log from Warning to Debug and includes new debug header. |
| source/SnmpPlugin/ccsp_scalar_helper_control.c | Lowers cache-handler registration log from Info to Debug and includes new debug header. |
| source/SnmpPlugin/ccsp_scalar_helper_access.c | Lowers “find destination component” log from Warning to Debug and includes new debug header. |
| source/SnmpPlugin/ccsp_mib_utilities.c | Lowers “find destination component” log from Warning to Debug and includes new debug header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+31
| #include <stdio.h> | ||
|
|
||
| #undef AnscTraceDebug | ||
| #define AnscTraceDebug(a) \ | ||
| do { \ | ||
| printf("%s:%d> ", __FUNCTION__, __LINE__); \ | ||
| printf a; \ | ||
| } while (0) | ||
|
|
Comment on lines
+20
to
+21
| #ifndef _CCSP_SNMP_DEBUG_H | ||
| #define _CCSP_SNMP_DEBUG_H |
jayasrikadiyal
changed the title
Author
|
Created another request with new changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: To reduce logging in SNMP module. https://ccp.sys.comcast.net/browse/RDKB-62887
Test Procedure: We should not see the Repeated logs with Deafult Log Level Info.
Risks: Low
Priority: P1
Signed-off-by: Jayasri Kadiyala Jayasri_Kadiyala@comcast.com