Conversation
…ing Video Playback
There was a problem hiding this comment.
Pull request overview
This PR addresses missing/unresponsive volume behavior by ensuring the resident UI’s Volume component handles volume mute/up/down keypresses even when another app is topmost (e.g., during video playback scenarios where focus may shift away from the resident app).
Changes:
- Invoke
this.tag("Volume").onVolumeMute()/onVolumeKeyUp()/onVolumeKeyDown()for volume keys even when a non-resident app is topmost. - Update log messages for volume up/down to reflect the correct action.
- Bump
accelerator-home-uiversion from6.0.10to6.0.11.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| accelerator-home-ui/src/App.js | Ensures volume key handling triggers the Volume overlay logic regardless of which app is currently topmost. |
| accelerator-home-ui/settings.json | Version bump to reflect the fix release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.