rebase by arun-madhavan-013 · Pull Request #170 · rdkcentral/rdke-refui

arun-madhavan-013 · 2026-04-01T17:55:21Z

No description provided.

…s also part of this

RDKEAPPRT-626,627,628,605,608,622 Fix error and uninstall overlay screen with bug fixes

RDKEAPPRT-612 :Add dac store details via RFC

…content (#162) * RDKEAPPRT-645 Add default error overlay when user tries to enter VOD content * Addressed the review comments

…e settings route

RDKEAPPRT-646 Create the Username, Password page and add it inside the settings route

RDKEAPPRT-621,606,648,644 fix for Language screen and powerstate issue

RDKEAPPRT-661 Add support for new authorization in App Catalog

…ging

To refresh the App store and main view when the authentication done

Signed-off-by: yashaswini-rk <yashaswini.ramakrishna@rdkcentral.com>

Creating Tag for 6.0.0

Feature/rdkeapprt 680 :Update to new RDK logos

Signed-off-by: yashaswini-rk <yashaswini.ramakrishna@rdkcentral.com>

Create tag 6.0.1

Copilot

Pull request overview

This PR updates the RefUI to the 6.0.1 release, introducing an authenticated App Catalog integration (with refresh events), new UI flows for catalog login and uninstall confirmation, and expanded in-app error handling via a new “FailOk” overlay widget.

Changes:

Add AppCatalog API module to support auth/refresh flows and service-tokenized download URLs, and route DAC catalog calls through it.
Add new UI components/flows: App Catalog login screen, “FailOk” (OK-only error) overlay widget, and an uninstall confirmation overlay for DAC apps.
Update routes/settings/versioning and assets to align with the 6.0.1 release (changelog, package config, settings.json, logos).

Reviewed changes

Copilot reviewed 25 out of 27 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
CHANGELOG.md	Adds entries for 6.0.0 / 6.0.1 / 5.0.24 releases.
bolt/package-configs/com.rdkcentral.refui.json	Bumps package version/dependency and modifies entry point.
accelerator-home-ui/static/images/splash/RDKLogo.png	Updates splash logo asset.
accelerator-home-ui/static/images/RDKLogo.png	Updates logo asset.
accelerator-home-ui/src/views/MainView.js	Listens for catalog refresh events and adds richer install/uninstall/launch/network error overlays.
accelerator-home-ui/src/views/AppStore.js	Reloads catalog on refresh events; adds error overlay handlers.
accelerator-home-ui/src/views/AppInfoPage.js	Adds uninstall confirmation overlay flow and refresh behavior on empty state.
accelerator-home-ui/src/screens/SplashScreens/LanguageScreen.js	Simplifies language handling (removes resident/FireBolt/RDKShell-specific paths).
accelerator-home-ui/src/screens/SettingsScreen.js	Adds “Connect to the Application Catalog” settings entry and updates navigation ordering.
accelerator-home-ui/src/screens/OtherSettingsScreens/LanguageScreen.js	Simplifies language handling (removes resident/FireBolt/RDKShell-specific paths).
accelerator-home-ui/src/screens/FailAndOkScreen.js	Introduces new OK-only error overlay widget (FailOk).
accelerator-home-ui/src/screens/AppCatalogLoginComponent.js	Adds UI for App Catalog login (username/password + on-screen keyboard).
accelerator-home-ui/src/routes/routes.js	Adds FailOk widget to relevant routes (apps/appinfo/menu).
accelerator-home-ui/src/routes/networkRoutes.js	Adds route for the App Catalog login screen.
accelerator-home-ui/src/overlays/UninstallConfirmation.js	New confirmation + uninstalling loader overlay component.
accelerator-home-ui/src/overlays/StatusProgress.js	Ensures label visibility during progress updates.
accelerator-home-ui/src/overlays/OtherSettings/LanguageScreenOverlay.js	Simplifies language overlay behavior (removes resident/FireBolt/RDKShell-specific paths).
accelerator-home-ui/src/keyIntercept/keyIntercept.js	Refactors key intercept payload structure for RDKWindowManager.
accelerator-home-ui/src/items/DacAppItem.js	Adds launch error handling and blocks “More Apps” navigation when offline.
accelerator-home-ui/src/items/AppCatalogItem.js	Adds error propagation to ancestors and resets progress between install cycles.
accelerator-home-ui/src/items/AppCard.js	Removes “primary” styling logic from action buttons.
accelerator-home-ui/src/AppController.js	Refactors key intercept payload structure for YouTube intercepts.
accelerator-home-ui/src/App.js	Adds FailOk widget; refines power-state comparisons; comments out FireBolt lifecycle listener registration.
accelerator-home-ui/src/api/DACApi.js	Routes catalog queries/download URLs through new AppCatalog API module.
accelerator-home-ui/src/api/AppCatalog.js	New authenticated catalog handler with refresh scheduling + legacy fallback.
accelerator-home-ui/src/api/AppApi.js	Changes Thunder `getRFCConfig` call shape to pass `rfcList`.
accelerator-home-ui/settings.json	Bumps app version to 6.0.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T17:59:51Z

  "name": "RDK Ref UI Home Screen",
  "packageType": "application",
-  "entryPoint": "file:///usr/share/refui/index.html",
+  "entryPoint": "--lightning --dev file:///usr/share/refui/index.html",


entryPoint now contains CLI-style flags ("--lightning --dev …") instead of a URI. If the package manager expects entryPoint to be a URL (as before), this will be an invalid entry point and can prevent the app from launching. Consider keeping entryPoint as the file URI and moving runtime flags to the appropriate configuration field/mechanism (or gating them to dev builds).

Suggested change

"entryPoint": "--lightning --dev file:///usr/share/refui/index.html",

"entryPoint": "file:///usr/share/refui/index.html",

Copilot · 2026-04-01T17:59:51Z

+      this.LOG('App Catalog Login - credentials submitted')
+      login(this.textCollection['EnterUsername'], this.textCollection['EnterPassword'])
+        .then(result => {
+          if (result) {
+            this.LOG('Login successful - navigating back')
+            if (!Router.isNavigating()) {
+              Router.back()
+            }
+          } else {
+            this.ERR('Login failed')
+          }
+        })
+        .catch(err => this.ERR('Login error: ' + err))
+    }


When login() returns false, the UI provides no user-visible feedback (only logs) and the user remains on the screen without guidance. Consider showing an error (e.g., via FailOk widget or inline text) and allowing retry without leaving the screen.

Copilot · 2026-04-01T17:59:51Z

+    {
+        path: 'settings/appcataloglogin',
+        component: AppCatalogLoginComponent,
+        widgets: ['Volume', 'AppCarousel']


The settings/appcataloglogin route does not include the FailOk widget, but the login screen likely needs a consistent way to display errors (e.g., invalid credentials / network). Consider adding FailOk (and Menu if consistent with other settings subroutes) to this route’s widgets list so errors can be surfaced predictably.

Suggested change

widgets: ['Volume', 'AppCarousel']

widgets: ['Menu', 'Fail', 'Volume', 'AppCarousel']

Copilot · 2026-04-01T17:59:52Z

+export const eventTarget = new EventTarget();
+
+export class AuthNeeded extends Event {
+  static eventName = 'authNeeded';
+
+  constructor() {
+    super(AuthNeeded.eventName);
+  }
+}


AuthNeeded is exported and dispatched, but there are no listeners in the codebase (search shows no usages outside this file). This makes auth-expiry handling effectively a no-op for users. Either wire this event up (e.g., navigate to the login screen / show a prompt) or remove the unused event to avoid dead code.

Copilot · 2026-04-01T17:59:52Z

 		}
 		this._getPowerStatebeforeReboot();
-		this._registerFireboltListeners()
+		// this._registerFireboltListeners()


The FireBolt lifecycle listener registration is currently disabled by commenting out the call. Leaving commented-out functional code in production paths makes behavior ambiguous and harder to maintain. Prefer deleting the dead code or guarding it behind an explicit runtime/config feature flag so it’s clear when/why these listeners should run.

Suggested change

// this._registerFireboltListeners()

Copilot · 2026-04-01T17:59:52Z

+const errorTitle = 'Error Title'
+const errorMsg = 'Error Message'


Default placeholder strings ('Error Title' / 'Error Message') are hard-coded and not translated; if the widget is focused before notify() is called, users may see these placeholders. Consider using Language.translate(...) (or empty defaults) to avoid exposing internal placeholder text.

Suggested change

const errorTitle = 'Error Title'

const errorMsg = 'Error Message'

const errorTitle = ''

const errorMsg = ''

… fix the accidental route happening to menu page when RCU key is received from FTU

…ive lifecycle

…ring-fix RDKEAPPRT-683: RemoteControl plugin API align with MW APIv3.4.2

Signed-off-by: suryag23 <surya_gunasekaran@comcast.com>

6.0.2

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

* Updated the version for refui boltpackage * Updated the version as 6.0.3

Signed-off-by: suryag23 <surya_gunasekaran@comcast.com>

6.0.3

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

…blank in the display (#180)

suryag23 and others added 30 commits March 19, 2026 20:12

Changes for the error and uninstall overlay screen then some bug fixe…

749f89d

…s also part of this

Merge branch '600' of https://github.com/rdkcentral/rdke-refui into 600

e35ed68

Addressed the review comments

bd9385e

Addressed the review comments

fff83e4

Addressed the review comments

3cd38bc

Merge pull request #161 from rdkcentral/600

29cece5

RDKEAPPRT-626,627,628,605,608,622 Fix error and uninstall overlay screen with bug fixes

RDKEAPPRT-612 :Add dac store details via RFC

7f0c809

RDKEAPPRT-612:dac store url via RFC

6f3b3a2

RDKEAPPRT-612 : Get DAC store details via RFC

0acb616

Merge pull request #160 from rdkcentral/feature/RDKEAPPRT-612

abee6ef

RDKEAPPRT-612 :Add dac store details via RFC

RDKEAPPRT-645 Add default error overlay when user tries to enter VOD …

19c9dca

…content (#162) * RDKEAPPRT-645 Add default error overlay when user tries to enter VOD content * Addressed the review comments

RDKEAPPRT-646 Create the Username, Password page and add it inside th…

b9dfca0

…e settings route

renamed the file

73208dd

Update the filename correctly

1af047b

Addressed the review comments

e57704c

Reneamed the DAC instance to Applicationcataloguelogin

361a48e

Merge pull request #163 from rdkcentral/600

5ace2a7

RDKEAPPRT-646 Create the Username, Password page and add it inside the settings route

RDKEAPPRT-621,606,648,644

2605f20

Addressed the review comments

692365c

Addressed the review comments

ebd8a03

Merge pull request #164 from rdkcentral/600

93128e3

RDKEAPPRT-621,606,648,644 fix for Language screen and powerstate issue

RDKEAPPRT-661 Add support for new authorization in App Catalog

da695ef

Merge pull request #165 from rdkcentral/feature/RDKEAPPRT-661

8ef221b

RDKEAPPRT-661 Add support for new authorization in App Catalog

RDKEAPPRT-646 Reload app catalog data after login

e772627

RDKEAPPRT-646 Reload app catalog data after login - Disable debug log…

90f4f8c

…ging

Merge pull request #166 from rdkcentral/feature/authenticationrefresh

e2eb61c

To refresh the App store and main view when the authentication done

RDKEAPPRT-677 Changelog and package config/version updates for 6.0.0

629ff83

Signed-off-by: yashaswini-rk <yashaswini.ramakrishna@rdkcentral.com>

Merge branch 'release/6.0.0'

12d01fe

Merge tag '6.0.0' into develop

ff076c2

Creating Tag for 6.0.0

RDKEAPPRT-680:Update the new logo files

c2b261f

yashaswini-rk and others added 4 commits March 31, 2026 22:46

Merge pull request #168 from rdkcentral/feature/RDKEAPPRT-680

8a86b48

Feature/rdkeapprt 680 :Update to new RDK logos

RDKEAPPRT-682 Changelog and package config version updates for 6.0.1

32bbba6

Signed-off-by: yashaswini-rk <yashaswini.ramakrishna@rdkcentral.com>

Merge branch 'release/6.0.1'

8574dda

Merge tag '6.0.1' into develop

a52a25f

Create tag 6.0.1

Copilot AI review requested due to automatic review settings April 1, 2026 17:55

Copilot started reviewing on behalf of arun-madhavan-013 April 1, 2026 17:55 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

arun-madhavan-013 and others added 12 commits April 2, 2026 14:32

RDKEAPPRT-683: RemoteControl plugin API align with MW APIv3.4.2

5520ae8

RDKEAPPRT-683: Fix the RCU pairing trigger timers

47df636

/RDKEAPPRT-683: stop the scan triggers after RCU pairing

34ee6be

RDKEAPPRT-683: fix the RCU re scanning logic leak.

2610642

RDKEAPPRT-683: fix the alignment issue - this change is introduced to…

7913317

… fix the accidental route happening to menu page when RCU key is received from FTU

RDKEAPPRT-683: fix typos and cleanup sequence

8add25c

RDKEAPPRT-683: initialize the var declared

65ec43f

fix(bluetooth-splash): prevent scanTrigger timer race across init/act…

641dae2

…ive lifecycle

Merge pull request #171 from rdkcentral/feature/RDKEAPPRT-683-rcu-pai…

8f9fb96

…ring-fix RDKEAPPRT-683: RemoteControl plugin API align with MW APIv3.4.2

RDKEAPPRT-687 Changelog updates for 6.0.2

ad290b1

Signed-off-by: suryag23 <surya_gunasekaran@comcast.com>

Merge branch 'release/6.0.2'

a829bf3

Merge tag '6.0.2' into develop

7d4582c

6.0.2

Copilot AI review requested due to automatic review settings April 7, 2026 07:18

Copilot AI reviewed Apr 7, 2026

View reviewed changes

suryag23 and others added 4 commits April 7, 2026 16:18

Updated the version for refui boltpackage (#175)

416c1b3

* Updated the version for refui boltpackage * Updated the version as 6.0.3

RDKEAPPRT-688 Changelog updates for 6.0.3

a64ad51

Signed-off-by: suryag23 <surya_gunasekaran@comcast.com>

Merge branch 'release/6.0.3'

a736f8d

Merge tag '6.0.3' into develop

c6030f2

6.0.3

Copilot AI review requested due to automatic review settings April 7, 2026 11:19

Copilot AI reviewed Apr 7, 2026

View reviewed changes

RDKMVE-2127 From Ref UI Home screen, Pressing Volume +/- leads to UI …

c638591

…blank in the display (#180)

arun-madhavan-013 closed this Apr 9, 2026

github-actions Bot locked and limited conversation to collaborators Apr 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rebase#170

rebase#170
arun-madhavan-013 wants to merge 52 commits into
feature/ledcontrol-supportfrom
develop

arun-madhavan-013 commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	"entryPoint": "--lightning --dev file:///usr/share/refui/index.html",
	"entryPoint": "file:///usr/share/refui/index.html",

	widgets: ['Volume', 'AppCarousel']
	widgets: ['Menu', 'Fail', 'Volume', 'AppCarousel']

		const errorTitle = 'Error Title'
		const errorMsg = 'Error Message'

Conversation

arun-madhavan-013 commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants