RDKMVE-447: Bring-in Status LED indication support#159
Open
arun-madhavan-013 wants to merge 4 commits into
Open
RDKMVE-447: Bring-in Status LED indication support#159arun-madhavan-013 wants to merge 4 commits into
arun-madhavan-013 wants to merge 4 commits into
Conversation
arun-madhavan-013
changed the title
There was a problem hiding this comment.
Pull request overview
Adds Status LED control support to the Accelerator Home UI by introducing a new Thunder-based LED control API and wiring LED state updates into Wi-Fi, Bluetooth, pairing, firmware update, failure, and factory reset flows.
Changes:
- Introduces
LEDControlApi(Thunder plugin wrapper) andLEDControlStateenum. - Updates multiple screens to set LED states during connecting/connected/error flows and restore LED state on exit.
- Activates LEDControl plugin during app init and syncs LED with power state changes.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| accelerator-home-ui/src/screens/WifiScreen.js | Sets WPS LED states for Wi-Fi scan/connect errors; restores LED on screen exit. |
| accelerator-home-ui/src/screens/WiFiPairingScreen.js | Sets WPS LED states during pairing/connect/connected/error; restores LED on exit. |
| accelerator-home-ui/src/screens/SplashScreens/NetworkList.js | Sets WPS LED states during splash network connection flow; restores LED on exit. |
| accelerator-home-ui/src/screens/SplashScreens/BluetoothScreen.js | Sets LED states during BT scan/pair success/error; restores LED on exit. |
| accelerator-home-ui/src/screens/RcInformationScreen.js | Updates LED on RC status/pairing actions; restores LED on exit. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FirmwareScreen.js | Sets USB upgrade LED state during download; restores LED after download / on disable. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js | Sets factory reset LED state during reset flow; attempts to restore LED later. |
| accelerator-home-ui/src/screens/JoinAnotherNetworkComponent.js | Restores LED on exit; attempts to set WPS_CONNECTING for manual join. |
| accelerator-home-ui/src/screens/FailScreen.js | Sets error LED state when showing fail screen; restores LED on disable. |
| accelerator-home-ui/src/screens/BluetoothScreen.js | Restores LED when leaving Bluetooth settings screen. |
| accelerator-home-ui/src/routes/otherSettingsRoutes.js | No functional change (formatting). |
| accelerator-home-ui/src/api/LEDControlApi.js | New LED control Thunder wrapper with support detection and state setting. |
| accelerator-home-ui/src/App.js | Activates LEDControl plugin and updates LED on power mode changes. |
| accelerator-home-ui/settings.json | Bumps UI version to 5.0.25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds a centralized Thunder-based LED control API and wires it into key UX flows (Wi‑Fi, Bluetooth/RC pairing, firmware update, factory reset, fail screen) so the device status LED reflects current user-facing state.
Changes:
- Introduces
LEDControlApi(org.rdk.LEDControl) withLEDControlState, support detection, activation, and state-setting helpers. - Sets LED states across Wi‑Fi connect/pairing/error flows, Bluetooth/RC pairing flows, firmware update download flow, and factory reset.
- Hooks LED state to power mode changes and resets LED back to power-state indication when leaving relevant screens.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| accelerator-home-ui/src/screens/WifiScreen.js | Set LED on Wi‑Fi scan/connect error; reset on screen inactive. |
| accelerator-home-ui/src/screens/WiFiPairingScreen.js | Drive LED for pairing/connect/connected/error; reset on inactive. |
| accelerator-home-ui/src/screens/SplashScreens/NetworkList.js | Drive LED for connect/connected/error during splash Wi‑Fi; reset on inactive. |
| accelerator-home-ui/src/screens/SplashScreens/BluetoothScreen.js | Drive LED for BT scan/pair success/failure and RC pairing start/error; reset on inactive. |
| accelerator-home-ui/src/screens/RcInformationScreen.js | Drive LED based on RC status and pairing start; reset on inactive. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FirmwareScreen.js | Set LED during firmware download and reset after completion. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js | Set LED for factory reset flow. |
| accelerator-home-ui/src/screens/JoinAnotherNetworkComponent.js | Set LED during “join another network” connect; reset on inactive. |
| accelerator-home-ui/src/screens/FailScreen.js | Set LED to error when fail screen is shown; reset on inactive. |
| accelerator-home-ui/src/routes/otherSettingsRoutes.js | No functional change (formatting only). |
| accelerator-home-ui/src/api/LEDControlApi.js | New Thunder API wrapper for LED control + supported-state caching. |
| accelerator-home-ui/src/App.js | Activate LEDControl on startup and mirror LED to power mode changes. |
| accelerator-home-ui/settings.json | Version bump to 5.0.25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds Status LED control to the Lightning UI by introducing a Thunder-based LEDControl API and wiring LED state transitions into Wi‑Fi, Bluetooth/RC pairing, firmware update, factory reset, and error screens.
Changes:
- Introduce
LEDControlApi(Thunderorg.rdk.LEDControl) with support detection and supported-state gating. - Update multiple screens to set LED states for connecting/connected/error flows and reset LED on screen exit.
- Initialize LEDControl plugin at app startup and bump app version.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| accelerator-home-ui/src/api/LEDControlApi.js | New Thunder wrapper for LED control and supported-state checks |
| accelerator-home-ui/src/App.js | Initialize LED control at startup; set LED on power mode changes; minor error-handling tweak |
| accelerator-home-ui/src/screens/WifiScreen.js | Set LED error/connecting during Wi‑Fi flows; reset LED on exit |
| accelerator-home-ui/src/screens/WiFiPairingScreen.js | Set LED state based on Wi‑Fi pairing/connect events; reset on exit |
| accelerator-home-ui/src/screens/SplashScreens/NetworkList.js | Set LED state for Wi‑Fi connect outcomes; reset on inactive |
| accelerator-home-ui/src/screens/SplashScreens/BluetoothScreen.js | Set LED state for BT scan/pairing and RC pairing; reset on inactive |
| accelerator-home-ui/src/screens/RcInformationScreen.js | Set/reset LED state during RC status/pairing |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FirmwareScreen.js | Indicate USB upgrade state during firmware download; reset on exit/failure |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js | Indicate factory reset state when reset begins |
| accelerator-home-ui/src/screens/JoinAnotherNetworkComponent.js | Indicate Wi‑Fi connecting; reset on inactive |
| accelerator-home-ui/src/screens/FailScreen.js | Indicate error state while fail screen is active; reset on exit |
| accelerator-home-ui/src/routes/otherSettingsRoutes.js | Formatting-only change |
| accelerator-home-ui/settings.json | Version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Adds Status LED indication support across the UI by introducing an LED control abstraction and wiring it into key Wi‑Fi/Bluetooth/pairing/firmware/reset flows, plus power-state synchronization from the app shell.
Changes:
- Introduce
LEDControlApi(LEDController) with supported-state probing and safesetLEDState()/matchLEDStateToPowerState()helpers. - Update multiple screens to drive LED states for connecting/connected/error and reset to power-state LED on exit.
- Initialize/activate LEDControl in
App.js, sync LED to power mode changes, and bump app version.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| accelerator-home-ui/src/api/LEDControlApi.js | New LED control wrapper over Thunder org.rdk.LEDControl, including supported state checks and power-state mapping. |
| accelerator-home-ui/src/App.js | Activates LEDControl (when supported) and updates LED on power mode changes. |
| accelerator-home-ui/src/screens/WifiScreen.js | Sets LED for Wi‑Fi scan/connect error and resets LED on screen exit. |
| accelerator-home-ui/src/screens/WiFiPairingScreen.js | Updates LED during Wi‑Fi pairing/connect lifecycle and resets on exit. |
| accelerator-home-ui/src/screens/SplashScreens/NetworkList.js | Drives LED for Wi‑Fi connect/connect-fail states and resets on inactive. |
| accelerator-home-ui/src/screens/SplashScreens/BluetoothScreen.js | Drives LED during Bluetooth/RC pairing flows and resets on inactive. |
| accelerator-home-ui/src/screens/RcInformationScreen.js | Drives LED based on RC connection/pairing status and resets on inactive. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FirmwareScreen.js | Sets LED during firmware download/upgrade flow and resets on failure/exit. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js | Sets LED to factory reset state when reset begins. |
| accelerator-home-ui/src/screens/JoinAnotherNetworkComponent.js | Sets LED to connecting when joining another network and resets on inactive. |
| accelerator-home-ui/src/screens/FailScreen.js | Sets LED to error on fail screen and resets on exit. |
| accelerator-home-ui/src/routes/otherSettingsRoutes.js | Formatting-only change. |
| accelerator-home-ui/settings.json | Version bump from 5.0.24 to 5.0.25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.