-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/rdkemw 8587 dlsym - Test #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/RDKEMW-8587-config-dlsym
Are you sure you want to change the base?
Changes from all commits
d3a2867
6abd424
59bbd5c
b08a24d
9cc6b5f
ade5a61
6ac6e50
2dc944b
f6f3d48
441361b
8d36de9
c676229
968901d
513b3c7
fb4785d
35661b4
4c52eeb
e645685
db4fa61
f5838f4
82e1bf4
2ee6669
f68259b
45e0530
43ad5ad
de32c1b
efe2f43
a84c6eb
2b96a08
703701e
0ba55bf
b69cb63
0b96ee2
32d57fb
7ae4eb6
cca3783
01776ad
17564c6
b8cdf99
898b0bb
a5b7a9f
62858d9
5dd27d7
6594764
3a73464
56fabff
8f0dd0f
f90a986
f11f7de
5b50634
05c2d95
2540d79
9e5074b
edc8c70
ab7a2df
664fd4f
c1e17e4
e3b7b2b
f8c568e
901a227
ef6597a
2a0902b
b4a0fba
31735bd
f2369dd
ea8f943
4534399
0cdf7e0
55f0c79
07a40d8
88716e5
d074e1d
0493378
ffe1449
69f17ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||||||||||||||
| /* | ||||||||||||||||||||
| * If not stated otherwise in this file or this component's LICENSE file the | ||||||||||||||||||||
| * following copyright and licenses apply: | ||||||||||||||||||||
|
Check failure on line 3 in ds/audioOutputPortConfig.hpp
|
||||||||||||||||||||
| * | ||||||||||||||||||||
| * Copyright 2016 RDK Management | ||||||||||||||||||||
| * | ||||||||||||||||||||
|
|
@@ -38,6 +38,14 @@ | |||||||||||||||||||
| #include <list> | ||||||||||||||||||||
| #include <string> | ||||||||||||||||||||
|
|
||||||||||||||||||||
| typedef struct audioConfigs | ||||||||||||||||||||
| { | ||||||||||||||||||||
| const dsAudioTypeConfig_t *pKConfigs; | ||||||||||||||||||||
| const dsAudioPortConfig_t *pKPorts; | ||||||||||||||||||||
| int *pKConfigSize; | ||||||||||||||||||||
| int *pKPortSize; | ||||||||||||||||||||
| }audioConfigs_t; | ||||||||||||||||||||
|
Comment on lines
+41
to
+47
|
||||||||||||||||||||
| typedef struct audioConfigs | |
| { | |
| const dsAudioTypeConfig_t *pKConfigs; | |
| const dsAudioPortConfig_t *pKPorts; | |
| int *pKConfigSize; | |
| int *pKPortSize; | |
| }audioConfigs_t; | |
| struct audioConfigs; | |
| typedef struct audioConfigs audioConfigs_t; |
Copilot
AI
Feb 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing AudioOutputPortConfig::load() to load(audioConfigs_t*) is an API-breaking change. There are existing callers still using the no-arg form (e.g., test/testConfigAOP.cpp:59 and test/testConfigVOP.cpp:60 from repo search), which will fail to compile unless updated. Consider keeping a no-arg overload that forwards to load(nullptr) (or update all call sites in the same PR).
| // Backward-compatible no-arg overload: delegates to pointer-based load. | |
| void load() { load(nullptr); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library now calls
dlopen/dlsym(seeds/manager.cpp), but the link command here only adds-lIARMBus -ldshalcli. On many systems you must also link-ldlto resolve these symbols. Consider adding-ldl(or ensuring$(DSHAL_LDFLAGS)already includes it) to avoid link failures.