Fix compatibility with node.js v16#28
Merged
Merged
Conversation
node:readline/promises is avaialble from node.js v17
There was a problem hiding this comment.
Pull request overview
This PR restores Node.js v16 compatibility by removing the dependency on node:readline/promises (introduced in newer Node versions) and replacing it with a small Promise wrapper around the callback-based readline API.
Changes:
- Switch from
node:readline/promisestonode:readline. - Add an internal
question()helper to provide an async/await-friendly prompt flow. - Update credential prompting to use the new helper for username/password input.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ansu-mathew
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node:readline/promises is avaialble from node.js v17