Skip to content

Add support for middleware based running in run#26

Merged
astolcenburg merged 1 commit into
rdkcentral:mainfrom
astolcenburg:main
Apr 7, 2026
Merged

Add support for middleware based running in run#26
astolcenburg merged 1 commit into
rdkcentral:mainfrom
astolcenburg:main

Conversation

@astolcenburg
Copy link
Copy Markdown
Contributor

Ref: #RDKEAPPRT-686

Copilot AI review requested due to automatic review settings April 3, 2026 16:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds middleware-aware execution to bolt run, allowing packages to be launched via AppManager/PackageManager when available, with a fallback to the existing direct (crun) execution path. This aligns run behavior with middleware installation state and extends the CLI/docs to support running by package ID, full name, or .bolt file.

Changes:

  • Introduces Thunder JSON-RPC response parsing and a dedicated ThunderError to standardize error handling.
  • Updates bolt run to auto-detect middleware availability/installation, optionally push .bolt files first, and adds --direct to force direct mode.
  • Adds remote middleware helpers (RemotePackageManager, RemoteAppManager) and updates CLI/docs accordingly.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
bolt/src/ThunderError.cjs Adds ThunderError + response parsing helper for Thunder JSON-RPC.
bolt/src/Remote.cjs Switches Thunder calls to parse/throw structured errors and return result directly.
bolt/src/RemotePackageManager.cjs Adds middleware package-manager wrapper (install/state/active).
bolt/src/RemoteAppManager.cjs Adds middleware app-manager wrapper (launch/focus/active).
bolt/src/push.cjs Refactors middleware install path to use RemotePackageManager + ThunderError.
bolt/src/run.cjs Implements middleware-first run with fallback to direct mode; adds --direct and remote-store deploy helper.
bolt/src/config.cjs Adds AppManager callsign config.
bolt/src/bolt.cjs Updates help text and plumbs raw CLI options through for warnings.
bolt/README.md Updates bolt run usage and links to new docs/run.md.
bolt/docs/run.md Adds detailed documentation for new bolt run behavior and modes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bolt/src/run.cjs Outdated
Comment thread bolt/src/RemoteAppManager.cjs
Comment thread bolt/docs/run.md
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bolt/src/ThunderError.cjs
Comment thread bolt/src/run.cjs Outdated
Comment thread bolt/src/bolt.cjs Outdated
Comment thread bolt/README.md Outdated
Comment thread bolt/src/run.cjs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bolt/src/ThunderError.cjs
Comment thread bolt/src/run.cjs
Comment thread bolt/docs/run.md
Comment thread bolt/docs/run.md
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bolt/src/push.cjs Outdated
Comment thread bolt/src/run.cjs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bolt/src/push.cjs Outdated
Comment thread bolt/src/run.cjs
Comment thread bolt/src/run.cjs Outdated
Comment thread bolt/src/RemoteAppManager.cjs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bolt/src/run.cjs
Comment thread bolt/src/push.cjs
@astolcenburg astolcenburg merged commit 9571363 into rdkcentral:main Apr 7, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants