Skip to content

Move the Extension interfaces to ThunderExtensions #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sramani-metro wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move the Extension interfaces to ThunderExtensions #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64c0e3f
Move the Extension interfaces to ThunderExtensions
sramani-metro Feb 20, 2026
bf59d50
Fix Windows builds
sramani-metro Feb 23, 2026
4ec5d14
Fix Windows build
sramani-metro Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion definitions/Definitions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
#include <interfaces/IPerformance.h>
#include <interfaces/IPlayerInfo.h>
#include <interfaces/IPlayGiga.h>
#include <interfaces/IPluginAsyncStateControl.h>
#include <interfaces/IPower.h>
#include <interfaces/IProvisioning.h>
#include <interfaces/IRemoteControl.h>
Expand Down
16 changes: 1 addition & 15 deletions definitions/Definitions.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,21 +219,7 @@
<Outputs Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(ProjectDir)../interfaces/json/JSubsystemControl.h</Outputs>
<Outputs Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(ProjectDir)../interfaces/json/JSubsystemControl.h</Outputs>
</CustomBuild>
<CustomBuild Include="..\interfaces\IPluginAsyncStateControl.h">
<Outputs Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(ProjectDir)../interfaces/json/JPluginAsyncStateControl.h</Outputs>
<Command Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">python "$(ToolPath)\JsonGenerator\JsonGenerator.py" -I "$(FrameworkPath)\" -I "$(ProjectDir)\" --keep-empty --case-convention legacy -c -j "$(ProjectDir)../interfaces" -o "$(ProjectDir)../interfaces/json" "%(FullPath)" --force</Command>
<OutputItemType Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">ClInclude</OutputItemType>
<Command Condition="'$(Configuration)|$(Platform)'=='Release|x64'">python "$(ToolPath)\JsonGenerator\JsonGenerator.py" -I "$(FrameworkPath)\" -I "$(ProjectDir)\" --keep-empty --case-convention legacy -c -j "$(ProjectDir)../interfaces" -o "$(ProjectDir)../interfaces/json" "%(FullPath)" --force</Command>
<Outputs Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(ProjectDir)../interfaces/json/JPluginAsyncStateControl.h</Outputs>
<Outputs Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(ProjectDir)../interfaces/json/JPluginAsyncStateControl.h</Outputs>
<Outputs Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(ProjectDir)../interfaces/json/JPluginAsyncStateControl.h</Outputs>
<Command Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">python "$(ToolPath)\JsonGenerator\JsonGenerator.py" -I "$(FrameworkPath)\" -I "$(ProjectDir)\" --keep-empty --case-convention legacy -c -j "$(ProjectDir)../interfaces" -o "$(ProjectDir)../interfaces/json" "%(FullPath)" --force</Command>
<Command Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">python "$(ToolPath)\JsonGenerator\JsonGenerator.py" -I "$(FrameworkPath)\" -I "$(ProjectDir)\" --keep-empty --case-convention legacy -c -j "$(ProjectDir)../interfaces" -o "$(ProjectDir)../interfaces/json" "%(FullPath)" --force</Command>
<OutputItemType Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">ClInclude</OutputItemType>
<OutputItemType Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">ClInclude</OutputItemType>
<OutputItemType Condition="'$(Configuration)|$(Platform)'=='Release|x64'">ClInclude</OutputItemType>
</CustomBuild>
<ClInclude Include="ValuePoint.h" />
<ClInclude Include="ValuePoint.h" />
<CustomBuild Include="..\interfaces\IMath.h">
<Outputs Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(ProjectDir)../interfaces/json/JMath.h</Outputs>
<Outputs Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(ProjectDir)../interfaces/json/JMath.h</Outputs>
Expand Down
5 changes: 1 addition & 4 deletions definitions/Definitions.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,6 @@
<CustomBuild Include="..\interfaces\ISubsystemControl.h">
<Filter>Interface Files</Filter>
</CustomBuild>
<CustomBuild Include="..\interfaces\IPluginAsyncStateControl.h">
<Filter>Interface Files</Filter>
</CustomBuild>
</ItemGroup>
<ItemGroup>
<None Include="..\jsonrpc\common.json">
Expand All @@ -281,4 +278,4 @@
<UniqueIdentifier>{59dae841-dc89-457c-b9f5-7f097f7f7906}</UniqueIdentifier>
</Filter>
</ItemGroup>
</Project>
</Project>
64 changes: 0 additions & 64 deletions interfaces/IPluginAsyncStateControl.h
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions interfaces/Ids.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,6 @@ namespace Exchange {

ID_SUBSYSTEM_CONTROL = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x590,

Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the ID_PLUGINASYNCSTATECONTROL* entries from the public Exchange::IDS enum is an ABI/API breaking change for any out-of-tree components that still use these RPC interface IDs, and it also makes it easier to accidentally reuse the same numeric IDs later. Consider keeping these values in Ids.h as reserved/deprecated constants (with a comment pointing to ThunderExtensions) to preserve backward compatibility and prevent ID collisions.

Suggested change
// Reserved/deprecated IDs for PluginAsyncStateControl.
// These values are kept to preserve ABI/API compatibility and to avoid ID reuse.
// See ThunderExtensions for the corresponding RPC interfaces.
ID_PLUGINASYNCSTATECONTROL = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x5A0,
ID_PLUGINASYNCSTATECONTROL_NOTIFICATION = ID_PLUGINASYNCSTATECONTROL + 1,

Copilot uses AI. Check for mistakes.
ID_PLUGINASYNCSTATECONTROL = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x5A0,
ID_PLUGINASYNCSTATECONTROL_ACTIVATIONCALLBACK = ID_PLUGINASYNCSTATECONTROL + 1,
};
}
}
4 changes: 1 addition & 3 deletions interfaces/Interfaces.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
<ClCompile Include="proxystubs\ProxyStubs_Performance.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_PlayerInfo.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_PlayGiga.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_PluginAsyncStateControl.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_Power.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_Provisioning.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_RemoteControl.cpp" />
Expand Down Expand Up @@ -141,7 +140,6 @@
<ClInclude Include="IPackager.h" />
<ClInclude Include="IPerformance.h" />
<ClInclude Include="IPlayGiga.h" />
<ClInclude Include="IPluginAsyncStateControl.h" />
<ClInclude Include="IPower.h" />
<ClInclude Include="IProvisioning.h" />
<ClInclude Include="IRPCLink.h" />
Expand Down Expand Up @@ -398,4 +396,4 @@
<Delete Files="@(JsonFolder)" />
<Delete Files="@(Definitions)" />
</Target>
</Project>
</Project>
4 changes: 1 addition & 3 deletions interfaces/Interfaces.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
<ClCompile Include="proxystubs\ProxyStubs_WebServer.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_WifiControl.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_ZigWave.cpp" />
<ClCompile Include="proxystubs\ProxyStubs_PluginAsyncStateControl.cpp" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="IAmazonPrime.h" />
Expand Down Expand Up @@ -143,9 +142,8 @@
<ClInclude Include="ValuePoint.h" />
<ClInclude Include="IIOConnector.h" />
<ClInclude Include="ISubsystemControl.h" />
<ClInclude Include="IPluginAsyncStateControl.h" />
</ItemGroup>
<ItemGroup>
<Text Include="CMakeLists.txt" />
</ItemGroup>
</Project>
</Project>
Loading