RDKB-64910 Improve cci process memory#26
Merged
gsathish86 merged 5 commits intoMay 14, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets CCI process memory/residual-file cleanup on TCXB7/TCXB8 by tightening config parsing and fixing missing frees/cleanup paths.
Changes:
- Treat empty
"ConnectionType"as “not provided” during STA management config decode. - Free heap allocations on previously leaking/error paths (
res_file,if_map). - Add
/tmp/cci_rescleanup on certain thread exit paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/tests/wlan_emu_test_param_sta_management.cpp |
Reject empty ConnectionType string to fall back to default selection logic. |
src/tests/wlan_emu_test_param_gateway_performance.cpp |
Free res_file after successful upload to avoid per-iteration leak. |
src/messages/wlan_emu_msg_hdlr.cpp |
Add /tmp/cci_res cleanup when the message handler thread exits. |
src/gateway_cci/wlan_emu.cpp |
Free if_map when external station manager init fails. |
src/external_agent_cci/wlan_ext_emu_tests.cpp |
Attempt to add /tmp/cci_res cleanup on abort path (currently unreachable). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Platforms:
TCXB7, TCXB8
Reason for change: To fix the memory leaks and remove residual files
Test Procedure: Run cci tests and look for leak/residual files
Risks: None
Priority: P1
Signed-off-by:Pavithra_Sundaravadivel@comcast.com