Skip to content

RDKB-64910 Improve cci process memory#26

Merged
gsathish86 merged 5 commits into
rdkcentral:developfrom
pavithrasundaravadivel:DEV_remove_residuals
May 14, 2026
Merged

RDKB-64910 Improve cci process memory#26
gsathish86 merged 5 commits into
rdkcentral:developfrom
pavithrasundaravadivel:DEV_remove_residuals

Conversation

@pavithrasundaravadivel
Copy link
Copy Markdown
Contributor

Impacted Platforms:
TCXB7, TCXB8
Reason for change: To fix the memory leaks and remove residual files

Test Procedure: Run cci tests and look for leak/residual files

Risks: None

Priority: P1

Signed-off-by:Pavithra_Sundaravadivel@comcast.com

Copilot AI review requested due to automatic review settings May 13, 2026 10:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets CCI process memory/residual-file cleanup on TCXB7/TCXB8 by tightening config parsing and fixing missing frees/cleanup paths.

Changes:

  • Treat empty "ConnectionType" as “not provided” during STA management config decode.
  • Free heap allocations on previously leaking/error paths (res_file, if_map).
  • Add /tmp/cci_res cleanup on certain thread exit paths.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/tests/wlan_emu_test_param_sta_management.cpp Reject empty ConnectionType string to fall back to default selection logic.
src/tests/wlan_emu_test_param_gateway_performance.cpp Free res_file after successful upload to avoid per-iteration leak.
src/messages/wlan_emu_msg_hdlr.cpp Add /tmp/cci_res cleanup when the message handler thread exits.
src/gateway_cci/wlan_emu.cpp Free if_map when external station manager init fails.
src/external_agent_cci/wlan_ext_emu_tests.cpp Attempt to add /tmp/cci_res cleanup on abort path (currently unreachable).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/external_agent_cci/wlan_ext_emu_tests.cpp Outdated
Comment thread src/messages/wlan_emu_msg_hdlr.cpp
@gsathish86 gsathish86 merged commit 411f0bf into rdkcentral:develop May 14, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants