RDKB-64639 Fix resource leaks in cci process#24
Merged
gsathish86 merged 1 commit intoMay 4, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses file descriptor/resource leaks in the CCI test execution paths by ensuring opened pipes/files and libpcap dump handles are properly closed on early returns and after use.
Changes:
- Close the gateway performance result file before aborting on unsupported
TopCmdOptions. - Add missing
pclose()/fclose()calls on error paths in the command test step to prevent leaked pipes/files. - Close libpcap dump handles (
pcap_dump_close) after writing/flush in both internal and external-agent pcap creation flows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/tests/wlan_emu_test_param_gateway_performance.cpp |
Closes the opened result FILE* before returning on invalid command option. |
src/tests/wlan_emu_test_param_command.cpp |
Ensures popen() pipes and optional capture files are closed on additional error paths. |
src/messages/wlan_emu_msg.cpp |
Adds pcap_dump_close() to release the dumper handle after writing the pcap. |
src/external_agent_cci/wlan_ext_emu_test_step_params.cpp |
Adds pcap_dump_close() to release the dumper handle after writing the pcap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Platforms:
TCXB7, TCXB8
Reason for change: Properly close the FD's before return
Test Procedure: Run any cci test and check for the FD count before/after test
Risks: None
Priority: P1
Signed-off-by:Pavithra_Sundaravadivel@comcast.com