Skip to content

RDKB-64619 Fix PR0270(BPI connectivity) failure on first iteration#22

Merged
gsathish86 merged 6 commits into
rdkcentral:developfrom
pavithrasundaravadivel:DEV_bpi_iter
Apr 27, 2026
Merged

RDKB-64619 Fix PR0270(BPI connectivity) failure on first iteration#22
gsathish86 merged 6 commits into
rdkcentral:developfrom
pavithrasundaravadivel:DEV_bpi_iter

Conversation

@pavithrasundaravadivel
Copy link
Copy Markdown
Contributor

Impacted Platforms:
All RDKB Platforms

Reason for change: Enter into proper namespace for iperf tests

Test Procedure: Run PR0270 testcase and check the status

Risks: None

Priority: P1

Signed-off-by:Pavithra_Sundaravadivel@comcast.com

Copilot AI review requested due to automatic review settings April 24, 2026 06:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes PR0270 (BPI connectivity) first-iteration failures by ensuring iperf steps correctly enter/leave the expected Linux network namespace and improving cleanup behavior when failures occur.

Changes:

  • Ensure leave_namespace() is invoked on iperf start-command failure paths (client/server) to avoid leaving the process in the wrong netns.
  • Add a fallback cleanup path for iperf stop steps that cannot resolve the referenced start step (attempts to terminate iperf3 via killall).
  • Update the OpenWrt build makefile to include additional hostap sources and enable CONFIG_AP.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/external_agent_cci/wlan_ext_emu.cpp Adds cleanup of the test object/message manager when the agent enters a fail state.
src/external_agent_cci/wlan_ext_emu_test_step_param_iperf_server.cpp Adds namespace cleanup on error; adds fallback stop behavior using killall.
src/external_agent_cci/wlan_ext_emu_test_step_param_iperf_client.cpp Same as server: improved namespace cleanup on error; fallback stop behavior using killall.
build/openwrt/makefile Adds hostap sources/flags (including CONFIG_AP) to the OpenWrt build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/external_agent_cci/wlan_ext_emu_test_step_param_iperf_server.cpp Outdated
Comment thread src/external_agent_cci/wlan_ext_emu_test_step_param_iperf_client.cpp Outdated
Comment thread build/openwrt/makefile
@gsathish86 gsathish86 merged commit ec0eec7 into rdkcentral:develop Apr 27, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants