RDKB-64619 Fix PR0270(BPI connectivity) failure on first iteration#22
Merged
gsathish86 merged 6 commits intoApr 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes PR0270 (BPI connectivity) first-iteration failures by ensuring iperf steps correctly enter/leave the expected Linux network namespace and improving cleanup behavior when failures occur.
Changes:
- Ensure
leave_namespace()is invoked on iperf start-command failure paths (client/server) to avoid leaving the process in the wrong netns. - Add a fallback cleanup path for iperf stop steps that cannot resolve the referenced start step (attempts to terminate iperf3 via
killall). - Update the OpenWrt build makefile to include additional hostap sources and enable
CONFIG_AP.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/external_agent_cci/wlan_ext_emu.cpp | Adds cleanup of the test object/message manager when the agent enters a fail state. |
| src/external_agent_cci/wlan_ext_emu_test_step_param_iperf_server.cpp | Adds namespace cleanup on error; adds fallback stop behavior using killall. |
| src/external_agent_cci/wlan_ext_emu_test_step_param_iperf_client.cpp | Same as server: improved namespace cleanup on error; fallback stop behavior using killall. |
| build/openwrt/makefile | Adds hostap sources/flags (including CONFIG_AP) to the OpenWrt build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Platforms:
All RDKB Platforms
Reason for change: Enter into proper namespace for iperf tests
Test Procedure: Run PR0270 testcase and check the status
Risks: None
Priority: P1
Signed-off-by:Pavithra_Sundaravadivel@comcast.com