RDKB-64347#1111
Open
navyasher wants to merge 1 commit intordkcentral:developfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to address multiple static-analysis/Coverity-style findings across the WiFi stack by tightening memory handling, concurrency, bounds checks, and failure handling in several utilities and sample/test paths.
Changes:
- Replace
rand()usage in a webconfig consumer sample with/dev/urandom-backed random values. - Add missing NULL checks and improve cleanup paths (e.g., allocation failures) in OVSDB utilities and PSM MacFilter handling.
- Fix concurrency and validation issues (mutex lock ordering, unsigned bounds checks) and correct pointer arithmetic for UUID offsets in OVSDB table upserts.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| source/sampleapps/webconfig_consumer_apis.c | Adds /dev/urandom-based helper and uses it in sample subdoc mutations. |
| source/dml/wifi_ssp/ssp_loop.c | Adds strdup() failure handling and adjusts cleanup on early return paths in MacFilter PSM write logic. |
| source/dml/tr_181/ml/cosa_wifi_dml.c | Adjusts instance number derivation and invalid-instance checks in SSID DML handlers. |
| source/core/wifi_ctrl_rbus_handlers.c | Moves queue count under mutex to avoid races when removing rows. |
| source/apps/levl/wifi_levl.c | Adds mutex protection for probe request map access; fixes unsigned radio validation. |
| lib/ovsdb/ovsdb_utils.c | Adds NULL checks for pair allocation before inserting into ds_tree. |
| lib/ovsdb/ovsdb_table.c | Fixes unsafe pointer arithmetic when deriving uuid from record + uuid_offset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Fixing high medium priority coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Kondamma_Kudumula@comcast.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.