Improve calendar time picker styling#133
Open
devin-ai-integration[bot] wants to merge 2 commits intoagentfrom
Open
Improve calendar time picker styling#133devin-ai-integration[bot] wants to merge 2 commits intoagentfrom
devin-ai-integration[bot] wants to merge 2 commits intoagentfrom
Conversation
- Add day labels (Mon-Fri) above each time picker column - Add 'to' separator between start and end time inputs - Restyle time inputs with subtle background, rounded corners, and orange focus ring matching the app's accent color - Align time picker columns horizontally with the calendar grid - Update test to handle duplicate day text from labels and calendar headers Co-Authored-By: Rahul Chalamala <rahul@chalamala.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
caltech-dev | 8c24b89 | Commit Preview URL Branch Preview URL |
Mar 11 2026, 08:02 PM |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Move margins to .time-controls CSS class so media queries can override them - Add mobile margin override (10px) for screens <= 767px - Remove aria-hidden from day labels so screen readers can see them - Add aria-label to Flatpickr inputs (e.g. 'Mon start time', 'Mon end time') - Mark 'to' separator as aria-hidden since it's decorative Co-Authored-By: Rahul Chalamala <rahul@chalamala.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve calendar time picker styling with day labels and refined inputs
Summary
Redesigns the time picker controls above the weekly calendar to look more polished and informative:
.time-picker/.flatpickr-inputCSS with a newinput.time-inputclass for input styling; layout uses inline styles (due to Tailwind CSS 4 layer specificity conflicts) while container margins stay in CSS for mobile responsivenessaria-labelattributes to each Flatpickr input (e.g. "Mon start time", "Mon end time") for screen reader accessibilityTest updated to use
getAllByTextsince the new day labels duplicate the text react-big-calendar already renders in its column headers.Before:
After:
Updates since last revision
Addressed Devin Review feedback (commit 8c24b89):
.time-controlsCSS class with@media (max-width: 767px)override (65px → 10px on mobile)aria-hiddenfrom day labels and addedaria-labelto Flatpickr inputs ("Mon start time", etc.) so screen readers properly associate each input with its weekday; marked "to" separator asaria-hiddensince it's decorativeReview & Testing Checklist for Human
aria-labelattributes render correctly on the actual<input>elements (check browser devtools) and that screen readers announce them properlyNotes
@layerspecificity issue. Container margins remain in CSS to enable mobile media query overrides. This is a pragmatic workaround but slightly reduces maintainability.