Fix ICS export section matching for non-sequential section numbers#132
Open
devin-ai-integration[bot] wants to merge 1 commit intoagentfrom
Open
Fix ICS export section matching for non-sequential section numbers#132devin-ai-integration[bot] wants to merge 1 commit intoagentfrom
devin-ai-integration[bot] wants to merge 1 commit intoagentfrom
Conversation
The ICS export used section.number - 1 === sectionId to match the selected section, which assumes section numbers are sequential and 1-indexed. Many Caltech courses have gaps in section numbers (e.g., 1, 2, 4, 5), causing the export to silently drop events for those courses. Fix by directly accessing the section via array index (course.courseData.sections[sectionId]), consistent with how the rest of the app resolves sections. Also adds a null-check for sectionId and a test case exercising non-sequential section numbers. Co-Authored-By: Rahul Chalamala <rahul@chalamala.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
caltech-dev | a92e772 | Commit Preview URL Branch Preview URL |
Mar 11 2026, 07:51 PM |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ICS export section matching for non-sequential section numbers
Summary
The ICS export used
section.number - 1 === course.sectionIdto find the selected section. This assumes section numbers are sequential and 1-indexed, but many Caltech courses have gaps in their section numbers (e.g.,[1, 2, 4, 5]— 35-55 affected courses per term). For those courses, the export silently produced zero events.The fix replaces the filter-by-number approach with direct array index access (
course.courseData.sections[course.sectionId]), consistent with how the rest of the app resolves sections. Also adds asectionId !== nullguard in the outer filter.Review & Testing Checklist for Human
.icsfile for a course with non-sequential section numbers (e.g., any research course like "Ae 200" or "Bi 22") and confirming events appear in your calendar appsectionId !== nullfilter addition doesn't change behavior for courses with no section selected (previously these would pass the.enabledfilter but produce no events from the inner filter — now they're excluded earlier)Notes